From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 82D221FF13C for ; Thu, 02 Apr 2026 15:38:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0899E1B1E9; Thu, 2 Apr 2026 15:38:54 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 02 Apr 2026 15:38:49 +0200 Message-Id: Subject: Re: [PATCH manager v4 28/28] ui: form: add crs auto rebalancing options From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260402124817.416232-1-d.kral@proxmox.com> <20260402124817.416232-29-d.kral@proxmox.com> In-Reply-To: <20260402124817.416232-29-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775137071270 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.502 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MHIRNJLY5OICRZXHYSNG3XTOLDGFFC4O X-Message-ID-Hash: MHIRNJLY5OICRZXHYSNG3XTOLDGFFC4O X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm, consider this On Thu Apr 2, 2026 at 2:44 PM CEST, Daniel Kral wrote: > ha-auto-rebalance-{method,margin,hold-duration,margin} require > ha-auto-rebalance to be enabled in the schema, therefore they are > disabled here unless ha-auto-rebalance is enabled. good measure > > The label width was enlared a bit, so that the longer labels for the > auto rebalancing options are more readable. > > Signed-off-by: Daniel Kral > --- > changes v3 -> v4: > - new! > - only changes from v1 are that a separate component is used now, it > uses a viewModel to disable fields that shouldn't be set, and widen > the label width a bit; > - also 'Margin' is 'Minimum Imbalance Improvement' in the UI +1, is more comprehensible imo=20 > > www/manager6/form/CRSOptions.js | 62 ++++++++++++++++++++++++++++++++- > 1 file changed, 61 insertions(+), 1 deletion(-) > [snip] Reviewed-by: Dominik Rusovac