Re: [PATCH manager] api: backup: add return schema for backup jobs

Lukas Wagner
2026-04-01T14:11:15Z

On Wed Apr 1, 2026 at 1:46 PM CEST, Thomas Lamprecht wrote:
> The convert_to_schedule method keeps the current starttime/dow params, but the
> API contract now is basically, dow and starttime might be there, if a vzdum.cron
> still exists and nobody updated/added/removed any backup job since a while, as
> that would convert them to the modern jobs.cfg, having keept the old vzdump.cron
> only around to ensure that PVE nodes with older pve-mananger in a cluster still
> handle pre-existing backup old-style jobs correctly.
> But that was introduced mostly in commit 305921b1a ("api/backup: handle new
> vzdump jobs") [0] back in PVE 7.1 days, so we probably can just drop that, and
> we probably also do not need to wait until a next major release, as vzdum.cron
> cannot really be used anymore in practice (besides manual editing, which I do
> not care that much for). And for the backup job API response it's rather a clear
> cut, schedule is _always_ present, starttime/dow basically never, and all (API)
> clients need to cope with schedule since PVE 7.1, so dropping it from the return
> schema and (not a must, but nicer) deleting them from the response should be fine.
>
> I know, it's a bit annoying to have those legacy ghosts in scope for such
> patches, but it has some value to clean a few of them up when they resurface,
> especially when doing this with the end goal of encoding such types in rust in
> pve-api-types for use with PDM, as all legacy cruft we can safely shave off can
> make our life simpler.
>
> [0]: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=305921b1a

Thanks for the detailed explanation, highly appreciated.

I've sent a follow-up, I hope this is what you've had in mind: