From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5B0B11FF13A for ; Wed, 01 Apr 2026 06:31:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF435E18C; Wed, 1 Apr 2026 06:32:06 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 01 Apr 2026 12:31:58 +0800 Message-Id: To: "Thomas Lamprecht" , Subject: Re: [PATCH v2 proxmox-acme 3/3] buildsys: run tests as part of dpkg-buildpackage From: "Kefu Chai" X-Mailer: aerc 0.20.0 References: In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775017865880 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.262 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UYBRO75ULXM33H6MPSWUUKROC5ZSITNO X-Message-ID-Hash: UYBRO75ULXM33H6MPSWUUKROC5ZSITNO X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Apr 1, 2026 at 12:15 AM CST, Thomas Lamprecht wrote: > Am 31.03.26 um 09:10 schrieb Kefu Chai: >> Add override_dh_auto_test to debian/rules so that make test is >> automatically executed during every package build, ensuring the >> schema and Makefile consistency checks are enforced at build time. > > This already happens though? dh_auto_test will already trigger any > "check" or "test" target if there's a Makefile present, and when > building a package without your patch here I can see that working. Yeah, it's already wired into the default dh helper. I ran into=20 "No rule to make target 'test'" when running "make test" from the top-level repo dir, where only the outer Makefile is located. That's=20 why I just went ahead and added this in the d/rules in hope to avoid=20 the same problem. But I missed the fact that the /Makefile actually=20 copies the *src* directory when building debian package. I just found the same pattern repeats itself in proxmox-biome. Will take a closer look at the Makefile under root directory next time. Thanks for pointing this out! > > Or am I missing something here? > >>=20 >> Signed-off-by: Kefu Chai >> --- >> debian/rules | 3 +++ >> 1 file changed, 3 insertions(+) >>=20 >> diff --git a/debian/rules b/debian/rules >> index f00dbc2..2118ffa 100755 >> --- a/debian/rules >> +++ b/debian/rules >> @@ -5,3 +5,6 @@ >> =20 >> %: >> dh $@ >> + >> +override_dh_auto_test: >> + $(MAKE) -C . -f Makefile test