From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1707C1FF137 for ; Tue, 31 Mar 2026 13:01:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 913E318A04; Tue, 31 Mar 2026 13:01:34 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 31 Mar 2026 13:01:01 +0200 Message-Id: Subject: Re: [PATCH ha-manager v3 35/40] implement automatic rebalancing From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Daniel Kral" , =?utf-8?q?Michael_K=C3=B6ppl?= , X-Mailer: aerc 0.21.0 References: <20260330144101.668747-1-d.kral@proxmox.com> <20260330144101.668747-36-d.kral@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774954805492 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.409 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: N3KHZQ6H5G5BQKWY2EODJY5JZ7E3AQX5 X-Message-ID-Hash: N3KHZQ6H5G5BQKWY2EODJY5JZ7E3AQX5 X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Mar 31, 2026 at 11:42 AM CEST, Daniel Kral wrote: [snip] > # ./perl-array-empty.pl > array1 value: $VAR1 =3D undef; > array1 first: $VAR1 =3D undef; > array2 value: $VAR1 =3D []; > array2 first: $VAR1 =3D undef; > array3 value: $VAR1 =3D [ > {} > ]; > array3 first: $VAR1 =3D {}; > array4 value: $VAR1 =3D [ > { > 'something' =3D> 'a' > }, > { > 'else' =3D> 'b' > } > ]; > array4 first: $VAR1 =3D { > 'something' =3D> 'a' > }; > > Or do you have another reproducer for this? > as discussed off-list, my intuition failed me here. I would've expected this to not work, but of course autovivification makes it work... >>> +} >>> + >>> +sub score_best_balancing_migrations_topsis { >>> + my ($self, $migration_candidates, $limit) =3D @_; >>> + >>> + die "implement in subclass"; >>> +} >>> + >>> +sub select_best_balancing_migration_topsis { >>> + my ($self, $migration_candidates) =3D @_; >>> + >>> + my $migrations =3D $self->score_best_balancing_migrations_topsis($= migration_candidates, 1); >>> + >>> + return $migrations->[0]; >>> +} >>> + >>> # Returns a hash with $nodename =3D> $score pairs. A lower $score is b= etter. >>> sub score_nodes_to_start_service { >>> my ($self, $sid) =3D @_; >>> diff --git a/src/PVE/HA/Usage/Dynamic.pm b/src/PVE/HA/Usage/Dynamic.pm >>> index 24c85a41..76d0feaa 100644 >>> --- a/src/PVE/HA/Usage/Dynamic.pm >>> +++ b/src/PVE/HA/Usage/Dynamic.pm >>> @@ -104,6 +104,39 @@ sub remove_service_usage { >>> $self->{haenv}->log('warning', "unable to remove service '$sid' us= age - $@") if $@; >>> } >>> =20 >> >> [snip]