Re: [PATCH ha-manager v3 29/40] add running flag to non-HA cluster service stats

Dominik Rusovac
2026-03-31T07:58:20Z

lgtm, consider this

On Mon Mar 30, 2026 at 4:30 PM CEST, Daniel Kral wrote:
> The running flag is needed to discriminate starting and started
> resources from each other, which is a required parameter for using the
> new add_service(...) method for the resource scheduling bindings.
>
> The HA Manager tracks whether HA resources are in 'started' state and
> whether the LRM acknowledged that these are running. For non-HA
> resources, the rrd_dump data contains a running flag for VM and CT
> guests.
>
> See the next patch for the usage implementations, which passes the
> running flag to the add_service(...) method, for more information about
> the details.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> changes v2 -> v3:
> - change the patch message and summary such that is clear that this
> patch is only really relevant to make non-HA cluster resources also
> have the running flag
>

[snip]