From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B75C01FF137 for ; Tue, 31 Mar 2026 10:20:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CE9AE12FA5; Tue, 31 Mar 2026 10:21:00 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 31 Mar 2026 10:20:26 +0200 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH ha-manager v3 32/40] test: add dynamic usage scheduler test cases From: "Dominik Rusovac" X-Mailer: aerc 0.20.0 References: <20260330144101.668747-1-d.kral@proxmox.com> <20260330144101.668747-33-d.kral@proxmox.com> In-Reply-To: <20260330144101.668747-33-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774945170999 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.481 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2NKI3DL3QN6NVKVOYPEGA4STEYD3PEP4 X-Message-ID-Hash: 2NKI3DL3QN6NVKVOYPEGA4STEYD3PEP4 X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm, consider this On Mon Mar 30, 2026 at 4:30 PM CEST, Daniel Kral wrote: > These test cases document the basic behavior of the scheduler using the > dynamic usage information of the HA resources with rebalance-on-start > being cleared and set respectively. > > As the mechanisms for the scheduler with static and dynamic usage > information are mostly the same, these test cases verify only the > essential parts, which are: > > - dynamic usage information is used correctly (for both test cases), and > - repeatedly scheduling resources with score_nodes_to_start_service(...) > correctly simulates that the previously scheduled HA resources are > already started > > Signed-off-by: Daniel Kral > --- > changes v2 -> v3: > - adapt the test-crs-dynamic-rebalance1 test case to correctly handle > the change in score_nodes_to_start_resource() as done by changing how > $running is set in add_service_usage() a few patches prior > [snip] Reviewed-by: Dominik Rusovac