From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2018E1FF137 for ; Tue, 31 Mar 2026 10:12:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CA3221285A; Tue, 31 Mar 2026 10:12:46 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 31 Mar 2026 10:12:40 +0200 Message-Id: Subject: Re: [PATCH ha-manager v3 30/40] usage: use add_service to add service usage to nodes From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260330144101.668747-1-d.kral@proxmox.com> <20260330144101.668747-31-d.kral@proxmox.com> In-Reply-To: <20260330144101.668747-31-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774944705656 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NXL6RBIQFGMB3SFATS5SIIIJ4GNZF5IE X-Message-ID-Hash: NXL6RBIQFGMB3SFATS5SIIIJ4GNZF5IE X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm, consider this On Mon Mar 30, 2026 at 4:30 PM CEST, Daniel Kral wrote: > The pve_static (and upcoming pve_dynamic) bindings expose the new > add_resource(...) method, which allow adding resources in a single call > with the additional running flag. > > The running flag is needed to discriminate starting and started HA > resources from each other, which is needed to correctly account for HA > resources for the dynamic load usage implementation in the next patch. > > This is because for the dynamic load usage, any HA resource, which is > scheduled to start by the HA Manager in the same round, will not be > accounted for in the next call to score_nodes_to_start_resource(...). > This is not a problem for the static load usage, because there the > current node usages are derived from the started resources on every > call already. > > Passing only the HA resources' 'state' property is not enough since the > HA Manager will move any HA resource from the 'request_start' (or > through other transient states such as 'request_start_balance' and a > successful 'migrate'/'relocate') into the 'started' state. > > This 'started' state is then picked up by the HA resource's LRM, which > will actually start the HA resource and if successful respond with a > 'SUCCESS' LRM result. Only then will the HA Manager acknowledges this by > adding the running flag to the HA resource's state. > > Signed-off-by: Daniel Kral > --- > changes v2 -> v3: > - fix setting $running flag only if state 'started' and running is set > or for any non-started state where current_node is set > - Additionally handle the case where only $target_node is set in > add_service(), which can only happen in specific cases; I have some > patches which inline this behavior in get_used_service_nodes() (should > be named something else later) to make this behavior more consise, but > that should be handled separately > - change the $service property names to kebab-case > [snip] Reviewed-by: Dominik Rusovac