From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CC5731FF137 for ; Tue, 31 Mar 2026 09:58:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1B8E0120FE; Tue, 31 Mar 2026 09:58:48 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 31 Mar 2026 09:58:12 +0200 Message-Id: Subject: Re: [PATCH ha-manager v3 29/40] add running flag to non-HA cluster service stats From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260330144101.668747-1-d.kral@proxmox.com> <20260330144101.668747-30-d.kral@proxmox.com> In-Reply-To: <20260330144101.668747-30-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774943837110 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GTJMAKVKJZTYMCSAGUHQC7CKPAHIC7FT X-Message-ID-Hash: GTJMAKVKJZTYMCSAGUHQC7CKPAHIC7FT X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm, consider this On Mon Mar 30, 2026 at 4:30 PM CEST, Daniel Kral wrote: > The running flag is needed to discriminate starting and started > resources from each other, which is a required parameter for using the > new add_service(...) method for the resource scheduling bindings. > > The HA Manager tracks whether HA resources are in 'started' state and > whether the LRM acknowledged that these are running. For non-HA > resources, the rrd_dump data contains a running flag for VM and CT > guests. > > See the next patch for the usage implementations, which passes the > running flag to the add_service(...) method, for more information about > the details. > > Signed-off-by: Daniel Kral > --- > changes v2 -> v3: > - change the patch message and summary such that is clear that this > patch is only really relevant to make non-HA cluster resources also > have the running flag > [snip] Reviewed-by: Dominik Rusovac