From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2D8AD1FF137 for ; Tue, 31 Mar 2026 09:40:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 59DCD11884; Tue, 31 Mar 2026 09:41:08 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 31 Mar 2026 09:40:34 +0200 Message-Id: Subject: Re: [PATCH perl-rs v3 13/40] pve-rs: resource-scheduling: use generic usage implementation From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260330144101.668747-1-d.kral@proxmox.com> <20260330144101.668747-14-d.kral@proxmox.com> In-Reply-To: <20260330144101.668747-14-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774942779054 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.458 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: C4JAQY6NEAS6LRL54APBAI673SYNIYZV X-Message-ID-Hash: C4JAQY6NEAS6LRL54APBAI673SYNIYZV X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm, consider this On Mon Mar 30, 2026 at 4:30 PM CEST, Daniel Kral wrote: > The proxmox_resource_scheduling crate provides a generic usage > implementation, which is backwards compatible with the pve_static > bindings. This reduces the static resource scheduling bindings to a > slightly thinner wrapper. > > This also exposes the new `add_resource(...)` binding, which allows > callers to add services with additional state other than the usage > stats. It is exposed as `add_service(...)` to be consistent with the > naming of the rest of the existing methods. > > Where it is sensible for the bindings, the documentation is extended > with a link to the documentation of the underlying methods. > > Signed-off-by: Daniel Kral > --- > changes v2 -> v3: > - require callers to handle the `current_node` not set invariant > themselves, as this is pve-ha-manager-specific behavior and simplifies > the logic a bit > - s/FromInto/From/ for PveResource impl > - use kebab-case for (de)serialization of `PveResource` > - make node_stats closure variable mutable instead of shadowing it in > the closure body again in StartedResourceAggregator::aggregate() > [snip] Reviewed-by: Dominik Rusovac