From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3B6281FF137 for ; Tue, 31 Mar 2026 08:11:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E2E2FB55; Tue, 31 Mar 2026 08:12:00 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 31 Mar 2026 08:11:24 +0200 Message-Id: Subject: Re: [PATCH proxmox v3 04/40] resource-scheduling: introduce generic scheduler implementation From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260330144101.668747-1-d.kral@proxmox.com> <20260330144101.668747-5-d.kral@proxmox.com> In-Reply-To: <20260330144101.668747-5-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774937428921 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AKEPI7UUJJ5ME5OPRRDB5H5663K5E3W3 X-Message-ID-Hash: AKEPI7UUJJ5ME5OPRRDB5H5663K5E3W3 X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: changes lgtm, consider this On Mon Mar 30, 2026 at 4:30 PM CEST, Daniel Kral wrote: > The existing score_nodes_to_start_resource(...) function is dependent on > the StaticNodeUsage and StaticServiceUsage structs. > > To use this function for other usage stats structs as well, declare > generic NodeStats and ResourceStats structs, that the users can convert > into. These are used to make score_nodes_to_start_resource(...) and its > documentation generic. > > The pve_static::score_nodes_to_start_service(...) is marked as > deprecated accordingly. The usage-related structs are marked as > deprecated as well as the specific usage implementations - including > their serialization and deserialization - should be handled by the > caller now. > > This is best viewed with the git option --ignore-all-space. > > No functional changes intended. > > Signed-off-by: Daniel Kral > --- > changes v2 -> v3: > - add Clone and Debug derives to Scheduler struct > - change second unlimited_cpu_resource_stats variable to > combined_resource_stats; was a Copy-Paste error > Reviewed-by: Dominik Rusovac