From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CDD291FF141 for ; Mon, 30 Mar 2026 14:46:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 53DB01FB4A; Mon, 30 Mar 2026 14:46:58 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 30 Mar 2026 14:46:23 +0200 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH ha-manager v2 32/40] test: add dynamic usage scheduler test cases From: "Dominik Rusovac" X-Mailer: aerc 0.20.0 References: <20260324183029.1274972-1-d.kral@proxmox.com> <20260324183029.1274972-33-d.kral@proxmox.com> In-Reply-To: <20260324183029.1274972-33-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774874729207 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.094 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: M6TJRXYIQJDW2GCERUSB34EWWS2PTOV4 X-Message-ID-Hash: M6TJRXYIQJDW2GCERUSB34EWWS2PTOV4 X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: As discussed off-list: test-crs-dynamic-rebalance1 is not yet appropriate, otherwise lgtm=20 On Tue Mar 24, 2026 at 7:30 PM CET, Daniel Kral wrote: > These test cases document the basic behavior of the scheduler using the > dynamic usage information of the HA resources with rebalance-on-start > being cleared and set respectively. > > As the mechanisms for the scheduler with static and dynamic usage > information are mostly the same, these test cases verify only the > essential parts, which are: > > - dynamic usage information is used correctly (for both test cases), and > - repeatedly scheduling resources with score_nodes_to_start_service(...) > correctly simulates that the previously scheduled HA resources are > already started > > Signed-off-by: Daniel Kral > --- > changes v1 -> v2: > - new! > > src/test/test-crs-dynamic-rebalance1/README | 3 + > src/test/test-crs-dynamic-rebalance1/cmdlist | 4 + > .../datacenter.cfg | 7 ++ > .../dynamic_service_stats | 7 ++ > .../hardware_status | 5 ++ > .../test-crs-dynamic-rebalance1/log.expect | 88 +++++++++++++++++++ > .../manager_status | 1 + > .../service_config | 7 ++ > .../static_service_stats | 7 ++ > src/test/test-crs-dynamic1/README | 4 + > src/test/test-crs-dynamic1/cmdlist | 4 + > src/test/test-crs-dynamic1/datacenter.cfg | 6 ++ > .../test-crs-dynamic1/dynamic_service_stats | 3 + > src/test/test-crs-dynamic1/hardware_status | 5 ++ > src/test/test-crs-dynamic1/log.expect | 51 +++++++++++ > src/test/test-crs-dynamic1/manager_status | 1 + > src/test/test-crs-dynamic1/service_config | 3 + > .../test-crs-dynamic1/static_service_stats | 3 + > 18 files changed, 209 insertions(+) > create mode 100644 src/test/test-crs-dynamic-rebalance1/README > create mode 100644 src/test/test-crs-dynamic-rebalance1/cmdlist > create mode 100644 src/test/test-crs-dynamic-rebalance1/datacenter.cfg > create mode 100644 src/test/test-crs-dynamic-rebalance1/dynamic_service_= stats > create mode 100644 src/test/test-crs-dynamic-rebalance1/hardware_status > create mode 100644 src/test/test-crs-dynamic-rebalance1/log.expect > create mode 100644 src/test/test-crs-dynamic-rebalance1/manager_status > create mode 100644 src/test/test-crs-dynamic-rebalance1/service_config > create mode 100644 src/test/test-crs-dynamic-rebalance1/static_service_s= tats > create mode 100644 src/test/test-crs-dynamic1/README > create mode 100644 src/test/test-crs-dynamic1/cmdlist > create mode 100644 src/test/test-crs-dynamic1/datacenter.cfg > create mode 100644 src/test/test-crs-dynamic1/dynamic_service_stats > create mode 100644 src/test/test-crs-dynamic1/hardware_status > create mode 100644 src/test/test-crs-dynamic1/log.expect > create mode 100644 src/test/test-crs-dynamic1/manager_status > create mode 100644 src/test/test-crs-dynamic1/service_config > create mode 100644 src/test/test-crs-dynamic1/static_service_stats [snip] Reviewed-by: Dominik Rusovac