Re: [PATCH ha-manager v2 32/40] test: add dynamic usage scheduler test cases

Dominik Rusovac
2026-03-30T12:46:32Z

As discussed off-list: test-crs-dynamic-rebalance1 is not yet
appropriate, otherwise lgtm

On Tue Mar 24, 2026 at 7:30 PM CET, Daniel Kral wrote:
> These test cases document the basic behavior of the scheduler using the
> dynamic usage information of the HA resources with rebalance-on-start
> being cleared and set respectively.
>
> As the mechanisms for the scheduler with static and dynamic usage
> information are mostly the same, these test cases verify only the
> essential parts, which are:
>
> - dynamic usage information is used correctly (for both test cases), and
> - repeatedly scheduling resources with score_nodes_to_start_service(...)
> correctly simulates that the previously scheduled HA resources are
> already started
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> changes v1 -> v2:
> - new!
>
> src/test/test-crs-dynamic-rebalance1/README | 3 +
> src/test/test-crs-dynamic-rebalance1/cmdlist | 4 +
> .../datacenter.cfg | 7 ++
> .../dynamic_service_stats | 7 ++
> .../hardware_status | 5 ++
> .../test-crs-dynamic-rebalance1/log.expect | 88 +++++++++++++++++++
> .../manager_status | 1 +
> .../service_config | 7 ++
> .../static_service_stats | 7 ++
> src/test/test-crs-dynamic1/README | 4 +
> src/test/test-crs-dynamic1/cmdlist | 4 +
> src/test/test-crs-dynamic1/datacenter.cfg | 6 ++
> .../test-crs-dynamic1/dynamic_service_stats | 3 +
> src/test/test-crs-dynamic1/hardware_status | 5 ++
> src/test/test-crs-dynamic1/log.expect | 51 +++++++++++
> src/test/test-crs-dynamic1/manager_status | 1 +
> src/test/test-crs-dynamic1/service_config | 3 +
> .../test-crs-dynamic1/static_service_stats | 3 +
> 18 files changed, 209 insertions(+)
> create mode 100644 src/test/test-crs-dynamic-rebalance1/README
> create mode 100644 src/test/test-crs-dynamic-rebalance1/cmdlist
> create mode 100644 src/test/test-crs-dynamic-rebalance1/datacenter.cfg
> create mode 100644 src/test/test-crs-dynamic-rebalance1/dynamic_service_stats
> create mode 100644 src/test/test-crs-dynamic-rebalance1/hardware_status
> create mode 100644 src/test/test-crs-dynamic-rebalance1/log.expect
> create mode 100644 src/test/test-crs-dynamic-rebalance1/manager_status
> create mode 100644 src/test/test-crs-dynamic-rebalance1/service_config
> create mode 100644 src/test/test-crs-dynamic-rebalance1/static_service_stats
> create mode 100644 src/test/test-crs-dynamic1/README
> create mode 100644 src/test/test-crs-dynamic1/cmdlist
> create mode 100644 src/test/test-crs-dynamic1/datacenter.cfg
> create mode 100644 src/test/test-crs-dynamic1/dynamic_service_stats
> create mode 100644 src/test/test-crs-dynamic1/hardware_status
> create mode 100644 src/test/test-crs-dynamic1/log.expect
> create mode 100644 src/test/test-crs-dynamic1/manager_status
> create mode 100644 src/test/test-crs-dynamic1/service_config
> create mode 100644 src/test/test-crs-dynamic1/static_service_stats

[snip]

Reviewed-by: Dominik Rusovac <d.rusovac@proxmox.com>