Re: [PATCH cluster v2 19/40] datacenter config: add auto rebalancing options

Dominik Rusovac
2026-03-30T06:01:50Z

see comment inline, otherwise lgtm

On Tue Mar 24, 2026 at 7:30 PM CET, Daniel Kral wrote:
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> changes v1 -> v2:
> - slightly changed wording here (as suggested by @Maximiliano)

[snip]

> + 'ha-auto-rebalance-hold-duration' => {
> + type => 'number',
> + optional => 1,
> + default => 3,
> + requires => 'ha-auto-rebalance',

as mentioned in
https://lore.proxmox.com/all/CALgSy_edrGdEqxts77qXgr-W331kMmrq1oH5dZMedfZvSDCnbw@mail.gmail.com/,
clarifying the unit of value 3 would be benficial

> + description => "The duration the threshold must be exceeded for to trigger an automatic"
> + . " resource balancing migration in HA rounds.",
> + },

[snip]

Reviewed-by: Dominik Rusovac <d.rusovac@proxmox.com>