Re: [PATCH cluster v2 19/40] datacenter config: add auto rebalancing options

Daniel Kral
2026-03-26T16:20:31Z

On Thu Mar 26, 2026 at 5:08 PM CET, Jillian Morgan wrote:
> On Tue, Mar 24, 2026 at 2:34 PM Daniel Kral <d.kral@proxmox.com> wrote:
>
>> + 'ha-auto-rebalance-hold-duration' => {
>> + type => 'number',
>> + optional => 1,
>> + default => 3,
>> + requires => 'ha-auto-rebalance',
>> + description => "The duration the threshold must be exceeded for
>> to trigger an automatic"
>> + . " resource balancing migration in HA rounds.",
>> + },
>>
>>
> What are the units of these duration numbers? Miliseconds or days? ;-)
> Perhaps it is the "HA rounds" part that is key here but the statement is
> unclear to me. Is that a duration, or a discrete number of events? How long
> is each "HA round"?
>
> Perhaps a clarification like this: "The number of HA Rounds for which
> the ha-auto-rebalance-threshold must be exceeded before triggering an
> automatic resource balancing migration."
> And perhaps an additional hint could be provided that an HA Round is "10
> seconds" (I think?)

Hi Jillian!

Thanks for taking a look!

You're right, there should be more emphasis on the 'HA rounds' part!

I thought about using seconds in v1, but I went with the HA rounds as in
'number of repeated tries' as that measure is a better guarantee.
Putting "The number of HA rounds" at the start makes the 'unit' for this
property also clearer, will change it to that and add a hint about the
length of the HA rounds.

Best regards

Daniel