Re: [PATCH perl-rs v2 10/40] pve-rs: resource-scheduling: remove pedantic error handling from remove_node

Dominik Rusovac
2026-03-27T09:37:52Z

lgtm

On Tue Mar 24, 2026 at 7:29 PM CET, Daniel Kral wrote:
> The error can only happen due to an error in
> add_service_usage_to_node(...), but prevents all the following
> service_nodes entries from being cleaned up correctly.
>
> While technically a API break, removing the error does not change any
> callers, which do not handle the error anyway. Additionally,
> remove_node(...) is only used in testing code in this package and
> pve-ha-manager, but is currently unused for production code.
>
> This change makes the implementation more consistent with the new
> proxmox_resource_scheduling::usage::Usage, which will replace this in
> a following patch.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> changes v1 -> v2:
> - new!

[snip]

Reviewed-by: Dominik Rusovac <d.rusovac@proxmox.com>