Re: [PATCH cluster v2 17/40] datacenter config: restructure verbose description for the ha crs option

Dominik Rusovac
2026-03-30T05:50:59Z

see comment inline, otherwise lgtm

On Tue Mar 24, 2026 at 7:30 PM CET, Daniel Kral wrote:
> This makes it a little easier to read and allows appending descriptions
> for other values with a cleaner diff.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> changes v1 -> v2:
> - new!
>
> src/PVE/DataCenterConfig.pm | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index d88b167..e7bc8f1 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -17,9 +17,12 @@ my $crs_format = {
> optional => 1,
> default => 'basic',
> description => "Use this resource scheduler mode for HA.",
> - verbose_description => "Configures how the HA manager should select nodes to start or "
> - . "recover services. With 'basic', only the number of services is used, with 'static', "
> - . "static CPU and memory configuration of services is considered.",
> + verbose_description => <<EODESC,
> +Configures how the HA Manager should select nodes to start or recover services:
> +
> +- with 'basic', only the number of services is used,
> +- with 'static', static CPU and memory configuration of services is considered.

- with 'static', static CPU and memory configuration of services are considered.

[snip]

Reviewed-by: Dominik Rusovac <d.rusovac@proxmox.com>