Re: [PATCH cluster v2 18/40] datacenter config: add dynamic load scheduler option

Dominik Rusovac
2026-03-30T05:53:31Z

see comment inline, otherwise lgtm

On Tue Mar 24, 2026 at 7:30 PM CET, Daniel Kral wrote:
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> changes v1 -> v2:
> - slightly changed wording (as suggested by @Maximiliano)
>
> src/PVE/DataCenterConfig.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index e7bc8f1..396c962 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -13,7 +13,7 @@ my $PROXMOX_OUI = 'BC:24:11';
> my $crs_format = {
> ha => {
> type => 'string',
> - enum => ['basic', 'static'],
> + enum => ['basic', 'static', 'dynamic'],
> optional => 1,
> default => 'basic',
> description => "Use this resource scheduler mode for HA.",
> @@ -21,7 +21,8 @@ my $crs_format = {
> Configures how the HA Manager should select nodes to start or recover services:
>
> - with 'basic', only the number of services is used,
> -- with 'static', static CPU and memory configuration of services is considered.
> +- with 'static', static CPU and memory configuration of services is considered,
> +- with 'dynamic', static and dynamic CPU and memory usage of services is considered.

- with 'static', static CPU and memory configuration of services are considered,
- with 'dynamic', static and dynamic CPU and memory usage of services are considered.

[snip]

Reviewed-by: Dominik Rusovac <d.rusovac@proxmox.com>