From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CBEE01FF136 for ; Mon, 23 Mar 2026 13:39:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A97316B55; Mon, 23 Mar 2026 13:39:39 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 23 Mar 2026 13:39:06 +0100 Message-Id: To: "Lukas Sichert" , Subject: Re: [PATCH manager 2/2] fix #7339: lvmthick: ui: add UI fields for option to free storage From: =?utf-8?q?Michael_K=C3=B6ppl?= X-Mailer: aerc 0.21.0 References: <20260323101506.56098-1-l.sichert@proxmox.com> <20260323101506.56098-3-l.sichert@proxmox.com> In-Reply-To: <20260323101506.56098-3-l.sichert@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774269500412 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HBNTT6V4LAHSGXNZSXAQHBRLKHQUVGFD X-Message-ID-Hash: HBNTT6V4LAHSGXNZSXAQHBRLKHQUVGFD X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Mar 23, 2026 at 11:14 AM CET, Lukas Sichert wrote: > In the previous commit the backend recieved the functionality to discard this is a bit weird to put in the commit message like that since in the commit history of pve-manager, there is no related previous commit. > allocated space of a VM disk on a SAN, when a VM is deleted. The backend > checks whether to use this option by parsing storage.cfg to see if > 'issue_blkdiscard' is set to 1. This variable will automatically be > stored into the config file if it is present in the 'PUT' API request. > To be able to append this to the API call, the variable needs > to be defined in the json-Schema, but this has also been added in the > previous commit. > > To enable a option to free storage in the Gui, create a checkbox with > the name 'issue_blkdiscard'. In the checkbox use cbind to evaluate > 'iscreate' from the component, to only autoenable on new creations of > LVM Storages. This checkbox also adds the 'issue_blkdiscard' > variable and its value to the return call. > [snip]