From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D890B1FF13C for ; Thu, 19 Mar 2026 10:35:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A589C1513D; Thu, 19 Mar 2026 10:35:19 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Mar 2026 10:35:14 +0100 Message-Id: From: "Daniel Kral" To: "Thomas Lamprecht" , Subject: Re: [RFC ha-manager 17/21] usage: add dynamic usage scheduler X-Mailer: aerc 0.21.0-38-g7088c3642f2c-dirty References: <20260217141437.584852-1-d.kral@proxmox.com> <20260217141437.584852-31-d.kral@proxmox.com> <20260318165820.81517-5-t.lamprecht@proxmox.com> In-Reply-To: <20260318165820.81517-5-t.lamprecht@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773912872031 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YQAGUV2UT27DTTEKE23IARX2LYE6PNZW X-Message-ID-Hash: YQAGUV2UT27DTTEKE23IARX2LYE6PNZW X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 18, 2026 at 5:54 PM CET, Thomas Lamprecht wrote: > On Tue, 17 Feb 2026, Daniel Kral wrote: >> --- a/src/PVE/HA/Usage/Dynamic.pm >> +++ b/src/PVE/HA/Usage/Dynamic.pm >> @@ -0,0 +1,99 @@ >> [...] >> + ->log('err', "unable to score nodes according to dynamic usage = for service '$sid' - $@"); > > Missing `if $@` guard here, so this logs an error on every successful > call AFAICT? > > Seems to get fixed in patch 20/21, but that means patches 17-19 spam the > log on every service placement, while we do not plan to partially apply > this, it still should be fixed in this commit. > > btw. the error message also says "static" in get_service_usage, fixed to > "dynamic" also only in 20/21 -- same thing, should be correct from the > start. Yes, I squashed incorrectly here, is already fixed in the revised series, thx! > >> --- a/src/PVE/HA/Manager.pm >> +++ b/src/PVE/HA/Manager.pm >> @@ -14,6 +14,7 @@ use PVE::HA::Rules::NodeAffinity qw(get_node_affinity)= ; >> [...] >> +use PVE::HA::Usage::Dynamic; > > This is unconditional, unlike the Static module which uses the guarded > `eval { require ... }` + `$have_static_scheduling` pattern. If the Rust > library is not installed, the entire HA Manager fails to load. > Should either follow the same guarded approach or we just make the rust > library unconditional, which is probably more than fine to do now. Will do so!