From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 250731FF13C
	for <inbox@lore.proxmox.com>; Thu, 19 Mar 2026 10:32:21 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 5813014ED5;
	Thu, 19 Mar 2026 10:32:34 +0100 (CET)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 19 Mar 2026 10:31:59 +0100
Message-Id: <DH6NKT7YNTGD.263LARFMAO5RI@proxmox.com>
Subject: Re: [RFC ha-manager 20/21] implement automatic rebalancing
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
 <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.21.0-38-g7088c3642f2c-dirty
References: <20260217141437.584852-1-d.kral@proxmox.com>
 <20260217141437.584852-34-d.kral@proxmox.com>
 <20260318165820.81517-6-t.lamprecht@proxmox.com>
In-Reply-To: <20260318165820.81517-6-t.lamprecht@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1773912677120
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.047 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: IX5SFDQKYLAB5MHMCAIL3KOJCSBHIMRN
X-Message-ID-Hash: IX5SFDQKYLAB5MHMCAIL3KOJCSBHIMRN
X-MailFrom: d.kral@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Wed Mar 18, 2026 at 5:54 PM CET, Thomas Lamprecht wrote:
> On Tue, 17 Feb 2026, Daniel Kral wrote:
>> --- a/src/PVE/HA/Manager.pm
>> +++ b/src/PVE/HA/Manager.pm
>> @@ -106,6 +116,148 @@ sub update_crs_scheduler_mode {
>> [...]
>> +    my $node_loads =3D $online_node_usage->calculate_node_loads();
>
> $node_loads is assigned here but never used FWICT.

Right, this was a remnant of logging these for debugging, but I removed
calculate_node_loads(...) entirely for the v2 as it currently is not
used at all. We can still expose it later if we need it.

>
> minor nit: sustained_imbalance_round resets on CRM failover since it is
> not persisted, which is probably fine, but maybe worth a short comment
> to convey that this is wanted.

Good catch, I'll add a comment for that!