From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E493A1FF13C for ; Thu, 19 Mar 2026 10:29:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B62E14B6B; Thu, 19 Mar 2026 10:29:11 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Mar 2026 10:29:07 +0100 Message-Id: From: "Daniel Kral" To: "Thomas Lamprecht" , Subject: Re: [RFC ha-manager 21/21] test: add basic automatic rebalancing system test cases X-Mailer: aerc 0.21.0-38-g7088c3642f2c-dirty References: <20260217141437.584852-1-d.kral@proxmox.com> <20260217141437.584852-35-d.kral@proxmox.com> <20260318165820.81517-7-t.lamprecht@proxmox.com> In-Reply-To: <20260318165820.81517-7-t.lamprecht@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773912504888 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TSWE26QMAVWHHX6DH6U6RYFUKXHZNJFA X-Message-ID-Hash: TSWE26QMAVWHHX6DH6U6RYFUKXHZNJFA X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 18, 2026 at 5:54 PM CET, Thomas Lamprecht wrote: > On Tue, 17 Feb 2026, Daniel Kral wrote: >> + test: add basic automatic rebalancing system test cases > > The 4 test cases cover the basics well. Some gaps AFAICT that might > worth considering for a v2 (or non-RFC), not sure how easily those can > be tested with current sim capabilities though: > > - test where hold_duration prevents a transient spike from triggering a > migration (i.e. spike resolves before the counter fires) Good idea! This should certainly be doable since the current implementation allows setting how many rounds it will need to trigger an actual migration. That way we can "bypass" the "one command batch per 5 HA Manager rounds" in the sim code. > - test where the margin check rejects a too-small improvement > - test with resource or node affinity rules in combination with CRS > - test with heterogeneous node sizes > - test for the TOPSIS method path > - test for static mode + auto-rebalance (only dynamic is tested), as we > want to keep this mode for the time being (like talked off list), > it would be nice to have that covered here too. The other ones should also be doable AFAICT now from a quick look - otherwise I'll note it here or in the v2 notes. Thanks for the suggestions, I'll add them for the v2!