From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CEB2F1FF13C for ; Thu, 19 Mar 2026 10:28:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CDF5114AAD; Thu, 19 Mar 2026 10:29:09 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Mar 2026 10:28:30 +0100 Message-Id: Subject: Re: [RFC ha-manager 11/21] env, resources: add dynamic node and service stats abstraction From: "Daniel Kral" To: "Thomas Lamprecht" , X-Mailer: aerc 0.21.0-38-g7088c3642f2c-dirty References: <20260217141437.584852-1-d.kral@proxmox.com> <20260217141437.584852-25-d.kral@proxmox.com> <20260318165820.81517-2-t.lamprecht@proxmox.com> In-Reply-To: <20260318165820.81517-2-t.lamprecht@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773912467668 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YH6URSJJVIT32DASTDOGSR7NXDABUXFU X-Message-ID-Hash: YH6URSJJVIT32DASTDOGSR7NXDABUXFU X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 18, 2026 at 5:54 PM CET, Thomas Lamprecht wrote: > On Tue, 17 Feb 2026, Daniel Kral wrote: >> --- a/src/PVE/HA/Sim/Env.pm >> +++ b/src/PVE/HA/Sim/Env.pm >> @@ -500,12 +500,24 @@ sub get_static_service_stats { >> [...] >> +sub get_dynamic_service_stats { >> + my ($self) =3D @_; >> + >> + return $self->{hardware}->get_dynamic_service_stats(); >> +} > > Sim::Hardware does not implements get_dynamic_service_stats and > get_dynamic_node_stats until patch 16/21, so if the dynamic scheduler > path gets exercised in between, the sim/test run will die - please keep > each commit functional on its own. Right, I've only gone for this because the dynamic scheduler isn't used anywhere until patch #17. I'll still put this at least at the end so that there's no suggestion that these can already be called here.