From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A42021FF13B for ; Wed, 11 Mar 2026 14:36:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D6C421C6D1; Wed, 11 Mar 2026 14:36:45 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 11 Mar 2026 14:36:41 +0100 Message-Id: Subject: Re: [PATCH docs v2 0/2] local-zfs: rephrase ARC limit To: "Maximiliano Sandoval" X-Mailer: aerc 0.20.0 References: <20260226084639.107816-1-m.sandoval@proxmox.com> In-Reply-To: <20260226084639.107816-1-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773236167282 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.119 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OYESGG4GUVDD3GNSLKBEGVQHDNRJLMGS X-Message-ID-Hash: OYESGG4GUVDD3GNSLKBEGVQHDNRJLMGS X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Feb 26, 2026 at 9:46 AM CET, Maximiliano Sandoval wrote: > See the first commit for more information. > > Regarding adding the manual page: It is not very obvious where to find th= e > documentation for the value (I was personally interested in the units for > zfs_arc_max). Only after a `man -Kw zfs_arc_max` I found zfs(4) (as its s= ole > output). > > I also considered just saying that we only fallback to ZFS' defaults with= out > specifying the exact values, perhaps only that they quite high compared t= o 10%. > > Differences from v1: > - Document that we used ZFS' defaults before 8.1 > - Use lowercase in commit message > > Maximiliano Sandoval (2): > local-zfs: rephrase ARC limit > local-zfs: add reference to the zfs(4) manual > > local-zfs.adoc | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) other than the small nit i left on the first commit, this looks alright to me, consider this: Reviewed-by: Shannon Sterz