From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5C8B01FF144 for ; Tue, 10 Mar 2026 10:19:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D62BE15395; Tue, 10 Mar 2026 10:19:04 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Mar 2026 17:18:26 +0800 Message-Id: To: "Thomas Lamprecht" , "Kefu Chai" , Subject: Re: [PATCH manager v1] add default pgettext/npgettext implementations to index.html.tpl From: "Kefu Chai" X-Mailer: aerc 0.20.0 References: <20260228060333.3268576-2-k.chai@proxmox.com> In-Reply-To: <20260228060333.3268576-2-k.chai@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773134278185 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.761 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TKETJEECD7BLHPQFD6CJLFE54WP23XH7 X-Message-ID-Hash: TKETJEECD7BLHPQFD6CJLFE54WP23XH7 X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Thomas, Could help review this change as well? It's similar to the other changes adding default implementations for the gettext() variant functions. Without these changes, we would not be able to introduce them to the=20 proxmox-i18n project. cheers, On Sat Feb 28, 2026 at 2:03 PM CST, Kefu Chai wrote: > This adds default implementations for pgettext() and npgettext() function= s > to prevent UI breakage when no language is selected. > > These functions are required for context-aware translations support added > to the proxmox-i18n tooling. > > Default implementations: > - pgettext(context, message): Returns message (ignores context) > - npgettext(context, singular, plural, count): Returns appropriate form > > When a language file is loaded, these defaults are replaced by the actual > translation functions from the i18n catalog. > > Signed-off-by: Kefu Chai > --- > www/index.html.tpl | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/www/index.html.tpl b/www/index.html.tpl > index 0c289bbe..74ee02d9 100644 > --- a/www/index.html.tpl > +++ b/www/index.html.tpl > @@ -27,6 +27,8 @@ > > [% END %] > [%- IF debug %]