From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 51AE01FF144 for ; Tue, 10 Mar 2026 09:52:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CBB5313F5D; Tue, 10 Mar 2026 09:51:55 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Mar 2026 16:51:45 +0800 Message-Id: Subject: Re: [PATCH pmg-gui] add default pgettext/npgettext implementations to pmg-index.html.tt From: "Kefu Chai" To: "Thomas Lamprecht" , "Kefu Chai" , X-Mailer: aerc 0.20.0 References: <20260228060757.3271160-1-k.chai@proxmox.com> In-Reply-To: <20260228060757.3271160-1-k.chai@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773132678067 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.770 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HC3QXUP6B25ZK7GO6HAALTEGCGOHB5HA X-Message-ID-Hash: HC3QXUP6B25ZK7GO6HAALTEGCGOHB5HA X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kefu Chai X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Thomas, Could you please help review this change? It is one of the changes to prepare us for the context-aware translation support. After all these change land, we will update proxmox-i18n to add support for pgettext() and npgettext(). cheers, On Sat Feb 28, 2026 at 2:07 PM CST, Kefu Chai wrote: > From: Kefu Chai > > This adds default implementations for pgettext() and npgettext() function= s > to prevent UI breakage when no language is selected. > > These functions are required for context-aware translations support added > to the proxmox-i18n tooling. > > Default implementations: > - pgettext(context, message): Returns message (ignores context) > - npgettext(context, singular, plural, count): Returns appropriate form > > When a language file is loaded, these defaults are replaced by the actual > translation functions from the i18n catalog. > > Signed-off-by: Kefu Chai > --- > pmg-index.html.tt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/pmg-index.html.tt b/pmg-index.html.tt > index 42a483a..10f9a2d 100644 > --- a/pmg-index.html.tt > +++ b/pmg-index.html.tt > @@ -26,6 +26,8 @@ > > [%- END %] > [% IF debug %]