From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 185821FF144 for ; Tue, 10 Mar 2026 08:53:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6CF5D128E0; Tue, 10 Mar 2026 08:52:56 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Mar 2026 15:52:14 +0800 Message-Id: Subject: Re: [PATCH proxmox-biome] add pgettext and npgettext to JavaScript globals From: "Kefu Chai" To: "Thomas Lamprecht" , "Kefu Chai" , X-Mailer: aerc 0.20.0 References: <20260228061320.3279182-1-k.chai@proxmox.com> In-Reply-To: <20260228061320.3279182-1-k.chai@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773129107901 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.778 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6SYIRYQ6BXVWUV4OTXAOGX7QQKFAAMBG X-Message-ID-Hash: 6SYIRYQ6BXVWUV4OTXAOGX7QQKFAAMBG X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kefu Chai X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Thomas, Could you please help review this change? It would help us to add the context-aware support to our gettext-based i18n. cheers, On Sat Feb 28, 2026 at 2:13 PM CST, Kefu Chai wrote: > From: Kefu Chai > > These context-aware gettext functions are now being used in > proxmox-i18n projects and need to be recognized as valid > global functions by biome to prevent undefined variable > errors during 'make deb'. > > Signed-off-by: Kefu Chai > --- > src/biome.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/biome.json b/src/biome.json > index cda44243..ea8709be 100644 > --- a/src/biome.json > +++ b/src/biome.json > @@ -128,7 +128,9 @@ > "Proxmox", > "eslint", > "ngettext", > - "gettext" > + "gettext", > + "pgettext", > + "npgettext" > ] > } > }