From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C082D1FF13B for ; Wed, 25 Feb 2026 16:07:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 069996971; Wed, 25 Feb 2026 16:08:43 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 25 Feb 2026 16:08:07 +0100 Message-Id: From: "Daniel Kral" To: "Dominik Rusovac" , Subject: Re: [PATCH proxmox] resource-scheduling: topsis: add context to 'unwraps' X-Mailer: aerc 0.21.0-38-g7088c3642f2c-dirty References: <20260225130639.282334-1-d.rusovac@proxmox.com> In-Reply-To: <20260225130639.282334-1-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772032070696 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GHXYAEL64VHGTD643QEXZXGSVF3QBYTW X-Message-ID-Hash: GHXYAEL64VHGTD643QEXZXGSVF3QBYTW X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the patch! On Wed Feb 25, 2026 at 2:06 PM CET, Dominik Rusovac wrote: > Adds context as to why particular 'unwraps' panic. > > Signed-off-by: Dominik Rusovac > --- > proxmox-resource-scheduling/src/topsis.rs | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/proxmox-resource-scheduling/src/topsis.rs b/proxmox-resource= -scheduling/src/topsis.rs > index 6d078aa6..25934f5b 100644 > --- a/proxmox-resource-scheduling/src/topsis.rs > +++ b/proxmox-resource-scheduling/src/topsis.rs > @@ -145,8 +145,10 @@ impl IdealAlternatives { > let min =3D fixed_criterion > .clone() > .min_by(|a, b| a.total_cmp(b)) > - .unwrap(); > - let max =3D fixed_criterion.max_by(|a, b| a.total_cmp(b)).un= wrap(); > + .expect("zero alternatives"); > + let max =3D fixed_criterion > + .max_by(|a, b| a.total_cmp(b)) > + .expect("zero alternatives"); Hm, it might make sense to fall back to sensible defaults here or return a Result<> (as this is only used internally in score_alternatives(...)) and return either an empty vec there or an error as well. > =20 > (best[n], worst[n]) =3D match criteria[n].maximize { > true =3D> (max, min), > @@ -234,8 +236,7 @@ macro_rules! criteria_struct { > $( > $crate::topsis::Criterion::new($crit_name.to_str= ing(), $crit_weight), > )* > - ]) > - .unwrap() > + ]).unwrap_or_else(|err| panic!("constructing criteria fa= iled: {err}")) > }); > =20 > impl From<$name> for [f64; $count_name] {