From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F40C31FF141 for ; Thu, 15 Jan 2026 05:00:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E04DE1E9B1; Thu, 15 Jan 2026 05:00:45 +0100 (CET) Mime-Version: 1.0 Date: Thu, 15 Jan 2026 12:00:36 +0800 Message-Id: From: "Kefu Chai" To: "Kefu Chai" , , "Wolfgang Bumiller" X-Mailer: aerc 0.20.0 References: <20260105140854.1216448-1-k.chai@proxmox.com> In-Reply-To: <20260105140854.1216448-1-k.chai@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768449594552 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.168 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-fuse-rs] Apply code formatting improvements for consistency X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Hey Wolfgang, could you please help review this change as well at your convenience? It's a lint change. On Mon Jan 5, 2026 at 10:08 PM CST, Kefu Chai wrote: > Changes: > - Sort imports alphabetically in use statements > - Add semicolon after return statement in error path > > Rationale: > 1. Import ordering: Alphabetically sorted imports improve code readability > and reduce merge conflicts. Changed imports follow the pattern of > sorting type/struct names before function names within the same crate. > > Examples: > - anyhow::{Error, bail, format_err} (Error before bail/format_err) > - tokio::signal::unix::{SignalKind, signal} (type before function) > - sys::{EntryParam, ROOT_ID, ReplyBufState} (alphabetical order) > > 2. Semicolon after return: In src/fuse_fd.rs:376, added semicolon after > the return statement for consistency with Rust style conventions. > While optional for return statements, rustfmt and most style guides > prefer explicit semicolons for uniformity. > > Impact: > - No functional changes - purely stylistic improvements > - Better alignment with standard Rust formatting tools (rustfmt) > - Improved code consistency across the codebase > > Signed-off-by: Kefu Chai > --- > examples/tmpfs/main.rs | 4 ++-- > src/fuse_fd.rs | 2 +- > src/lib.rs | 2 +- > src/session.rs | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/examples/tmpfs/main.rs b/examples/tmpfs/main.rs > index 8ca7f9e..0f7e9c2 100644 > --- a/examples/tmpfs/main.rs > +++ b/examples/tmpfs/main.rs > @@ -3,11 +3,11 @@ use std::ffi::OsStr; > use std::path::Path; > use std::{io, mem}; > > -use anyhow::{bail, format_err, Error}; > +use anyhow::{Error, bail, format_err}; > use futures::future::FutureExt; > use futures::select; > use futures::stream::TryStreamExt; > -use tokio::signal::unix::{signal, SignalKind}; > +use tokio::signal::unix::{SignalKind, signal}; > > use proxmox_fuse::requests::{self, FuseRequest, SetTime}; > use proxmox_fuse::{EntryParam, Fuse, ReplyBufState, Request}; > diff --git a/src/fuse_fd.rs b/src/fuse_fd.rs > index 9205615..ae292b8 100644 > --- a/src/fuse_fd.rs > +++ b/src/fuse_fd.rs > @@ -374,7 +374,7 @@ fn poll_thread_inner(poll: Arc, fd: RawFd, state: Arc) -> io:: > return Err(io::Error::new( > io::ErrorKind::Other, > "epoll_wait returned unexpected events", > - )) > + )); > } > } > } > diff --git a/src/lib.rs b/src/lib.rs > index df509ec..32abbe9 100644 > --- a/src/lib.rs > +++ b/src/lib.rs > @@ -5,7 +5,7 @@ pub(crate) mod sys; > pub(crate) mod util; > > #[doc(inline)] > -pub use sys::{EntryParam, ReplyBufState, ROOT_ID}; > +pub use sys::{EntryParam, ROOT_ID, ReplyBufState}; > > #[doc(inline)] > pub use requests::Request; > diff --git a/src/session.rs b/src/session.rs > index a38593e..62a8a9e 100644 > --- a/src/session.rs > +++ b/src/session.rs > @@ -9,7 +9,7 @@ use std::sync::Arc; > use std::task::{Context, Poll}; > use std::{io, mem}; > > -use anyhow::{bail, format_err, Error}; > +use anyhow::{Error, bail, format_err}; > use futures::ready; > use futures::stream::{FusedStream, Stream}; > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel