From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4D4091FF17A for ; Tue, 23 Dec 2025 16:50:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE0693E2B; Tue, 23 Dec 2025 16:51:19 +0100 (CET) Mime-Version: 1.0 Date: Tue, 23 Dec 2025 16:51:15 +0100 Message-Id: From: "Max R. Carrara" To: "Maximiliano Sandoval" X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20251222141907.400926-1-m.carrara@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1766505057231 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH pve-manager v2 0/6] Fix #6816: Prevent ceph-exporter Daemon from Crashing on Startup - v2 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue Dec 23, 2025 at 1:43 PM CET, Maximiliano Sandoval wrote: > "Max R. Carrara" writes: > > > Fix #6816: Prevent ceph-exporter Daemon from Crashing on Startup - v2 > > ===================================================================== > > > > tl;dr: Stop ceph-exporter.service from ending up in a crash loop by > > handing it a custom keyring file and setting its group to `www-data`, > > similar to what we did for ceph-crash.service [0] before. > > > > This is a refresh of a somewhat older series that has been rebased, with > > the version guard in `debian/postinst` adapted. The description from the > > previous version is provided here again for the reader's convenience. > > > > Currently, the `ceph-exporter` daemon ends up in a short startup crash > > loop before ultimately failing to start at all, because it tries to > > access the keyring file at `/etc/pve/priv/ceph.client.admin.keyring`, > > for which it doesn't have the permissions to do so. > > > > Instead of giving it access to the admin ring, give it its own keyring > > located at `/etc/pve/ceph/ceph.client.exporter.keyring`. This file and > > its corresponding section in `/etc/pve/ceph.conf` is created when the > > first MON is created via the API. If the cluster has already been set > > up, a postinst hook creates the keyring file and adapts > > `/etc/pve/ceph.conf` instead. > > > > The core logic of all of this was already added for `ceph-crash` a while > > ago [0] and is reused throughout the series, with some alterations to > > the original code in order to make it a little more generic. > > I tested this series and it works as advertised modulo a race condition: > > When the ceph-exporter unit is started before installing this series it > will fail and systemd will retry a handful of times, during this time > `systemctl is-failed ceph-exporter.service` returns 'activating' instead > of 'failed'. This might explain that then the reset-failed is never > called. This results in ceph-exporter being restarted as part of the > postinst script but failing because the reset-failed was never called > and there have been too many attempts already. > > Otherwise, it works as expected. Thanks! > > Tested-by: Maximiliano Sandoval Thanks a ton for testing this! That's a really good catch. As discussed off-list, `ceph-exporter` won't be reset and restarted anymore in debian/postinst. See v3 [0] for an update. [0]: https://lore.proxmox.com/pve-devel/20251223153419.507507-1-m.carrara@proxmox.com/ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel