Re: [pve-devel] [PATCH ha-manager v3 00/21] HA rules fixes + performance improvements + cleanup

["Daniel Kral" <d.kral@proxmox.com>]

On Mon Nov 3, 2025 at 6:43 PM CET, Michael Köppl wrote:
> Gave v3 another spin after having reviewed v1. I again repeated the
> following scenarios:
> - Checked behavior with ignored resources (i.e. that ignored resources
>   are not shown as dependent resources when migrating).
> - Checked that conflicts between positive resource affinity rules and
>   node affinity rules are detected correctly in the cases that weren't
>   detected before
> - Checked various combinations of node affinity and resource affinity
>   rules, also checking the failback flag, max. restart, and max.
>   relocate params. Could not create any configurations that are
>   problematic.
> - Ran group migrations again (also making them fail on purpose and
>   checking that it keeps trying to migrate) to check that the changes
>   to the counting of active services did not alter behavior.
>
> Since this is now based on the granular accounting series [0], there is
> a problem with 'ignored' resources, which I noted separately on that
> patch series [1].
>
> Other than that I did not notice anything off. Everything seems to work
> as expected. Also had a look at the parts of the code that did not have
> my R-b anymore. My comments on v1 have been addressed in v2 already and
> the remaining changes in v3 lgtm. I think the addition of the benchmark
> on 10/21 is nice!
>
> Please consider this:
> Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
> Tested-by: Michael Köppl <m.koeppl@proxmox.com>

Thanks for taking a look and checking the series again!

I fixed the auto-vivification in the granular scheduling v4 series +
ha-manager patch #4 in the v4 of this series, thanks for pointing it
out! :)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel