From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D51071FF17E for ; Thu, 13 Nov 2025 09:57:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BD9A415941; Thu, 13 Nov 2025 09:58:45 +0100 (CET) Mime-Version: 1.0 Date: Thu, 13 Nov 2025 09:58:41 +0100 Message-Id: From: "Daniel Kral" To: "Thomas Lamprecht" , "Proxmox VE development discussion" , "Daniel Kral" X-Mailer: aerc 0.21.0-10-gf12c391cb5b4 References: <20251027164513.542678-1-d.kral@proxmox.com> <20251027164513.542678-2-d.kral@proxmox.com> <3e981812-deeb-4909-a5d4-bf5a204ac051@proxmox.com> In-Reply-To: <3e981812-deeb-4909-a5d4-bf5a204ac051@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763024296090 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox v3 1/1] resource-scheduling: change score_nodes_to_start_service signature X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed Nov 12, 2025 at 12:01 PM CET, Thomas Lamprecht wrote: > Am 27.10.25 um 17:46 schrieb Daniel Kral: >> This is needed as StaticNodeUsage is created in each invocation of >> PVE::RS::ResourceScheduling::Static::score_nodes_to_start_service now. >> >> Signed-off-by: Daniel Kral >> Reviewed-by: Fiona Ebner >> --- >> proxmox-resource-scheduling/src/pve_static.rs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/proxmox-resource-scheduling/src/pve_static.rs b/proxmox-resource-scheduling/src/pve_static.rs >> index d39614cd..fc40cb5c 100644 >> --- a/proxmox-resource-scheduling/src/pve_static.rs >> +++ b/proxmox-resource-scheduling/src/pve_static.rs >> @@ -70,7 +70,7 @@ criteria_struct! { >> /// Returns a vector of (nodename, score) pairs. Scores are between 0.0 and 1.0 and a higher score >> /// is better. >> pub fn score_nodes_to_start_service( >> - nodes: &[&StaticNodeUsage], >> + nodes: &[StaticNodeUsage], > > Or keep it backward compatible using generics and an AsRef bound: > > pub fn score_nodes_to_start_service>( > nodes: &[T], > ) { > > Not something I'd heavily promote do always do, but for one such changes are > not required very often in the first place, and being able to bump and roll > out this while still allowing to build and bump pve-rs without your changes > there has its small benefits. > That said, generics will result in multiple copies of the function (one per > actual type used), but that is mostly a problem for bigger methods, albeit > there one often can move the actual impl to a dedicated private fn and let > the public fn just handle "resolving" the generics and calling into the > actual impl). Here we will just use a single type anyway, just switching that > from a ref to a value, so the generic has no real practical cost for us and > thus would be worthwhile. I should use Git Notes more often again, I had a small comment about this in the original patch series contemplating this ;) Will go for that approach to minimize the cost of versioned breaks! > >> service: &StaticServiceUsage, >> ) -> Result, Error> { >> let len = nodes.len(); _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel