From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 120241FF15E for ; Mon, 10 Nov 2025 10:46:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9EB3B11253; Mon, 10 Nov 2025 10:47:42 +0100 (CET) Mime-Version: 1.0 Date: Mon, 10 Nov 2025 10:47:39 +0100 Message-Id: From: "Daniel Kral" To: "Proxmox VE development discussion" X-Mailer: aerc 0.21.0-10-gf12c391cb5b4 References: <20251107144429.126790-1-f.ebner@proxmox.com> In-Reply-To: <20251107144429.126790-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762768036899 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH-SERIES qemu-server/manager v2 0/8] VM CPU flags: introduce vendor-agnostic 'nested-virt' CPU flag X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Nov 7, 2025 at 3:43 PM CET, Fiona Ebner wrote: > Changes in v2 (thanks Dano and Thomas!): > * Pass running CPU configuration when using 'nested-virt'. This > ensures that migration fails early if the flag resolves differently > on the target. > * Describe that live migration still only works if it's the same flag. > * Drop adding non-existing link in API end point. > * Keep $supported_cpu_flags private to module and add getter method. > * Unpack @_ first at the beginning of resolve_cpu_flags(). > * ui: fix function call in the CPU flag selector widget. > * ui: use simpler method to get all records of the store. > * Drop already applied patches. Had another look at the patches and tested the same as last time (different combinations of {+,-}nested-virt and {+,-}vmx on Intel host in custom cpu model and cpu flags). As I don't have a mixed-vendor (AMD/Intel) cluster ready, I couldn't test whether the migration would abort if e.g. I were to live migrate a VM with "+svm" to a Intel host, but from an off-list demonstration from @Fiona and the code I assume that this works the same as starting a VM with "+svm" on an Intel host, which results in the fatal error below: kvm: warning: host doesn't support requested feature: CPUID[eax=80000001h].ECX.svm [bit 2] kvm: Host doesn't support requested features Otherwise, the changes from v1 to v2 and the patches overall look good to me, so consider this as: Reviewed-by: Daniel Kral Tested-by: Daniel Kral _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel