From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BACD81FF165 for ; Thu, 6 Nov 2025 15:32:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 612B119B28; Thu, 6 Nov 2025 15:32:44 +0100 (CET) Mime-Version: 1.0 Date: Thu, 06 Nov 2025 15:32:39 +0100 Message-Id: From: "Daniel Kral" To: "Proxmox VE development discussion" X-Mailer: aerc 0.21.0-10-gf12c391cb5b4 References: <20251020141335.124077-1-f.ebner@proxmox.com> <20251020141335.124077-14-f.ebner@proxmox.com> In-Reply-To: <20251020141335.124077-14-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762439540476 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.985 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_MAILER 2 Automated Mailer Tag Left in Email RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [helpers.pm] Subject: Re: [pve-devel] [PATCH qemu-server v2 13/16] introduce QSD module for qemu-storage-daemon functionality X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon Oct 20, 2025 at 4:13 PM CEST, Fiona Ebner wrote: > diff --git a/src/PVE/QemuServer/Helpers.pm b/src/PVE/QemuServer/Helpers.pm > index ce9c352a..35c00754 100644 > --- a/src/PVE/QemuServer/Helpers.pm > +++ b/src/PVE/QemuServer/Helpers.pm > @@ -89,6 +89,39 @@ sub qsd_pidfile_name { > return "${var_run_tmpdir}/qsd-${id}.pid"; > } > > +sub qsd_fuse_export_cleanup_files { > + my ($id) = @_; > + > + # Usually, /var/run is a symlink to /run. It needs to be the exact path for checking if mounted > + # below. Note that Cwd::realpath() needs to be done on the directory already. Doing it on the > + # file does not work if the storage daemon is not running and the FUSE is still mounted. > + my ($real_dir) = Cwd::realpath($var_run_tmpdir) =~ m/^(.*)$/; # untaint > + if (!$real_dir) { > + warn "error resolving $var_run_tmpdir - not checking for left-over QSD files\n"; > + return; > + } > + > + my $mounts = PVE::ProcFSTools::parse_proc_mounts(); > + > + PVE::Tools::dir_glob_foreach( > + $real_dir, > + "qsd-${id}-.*\.fuse", > + sub { > + my ($file) = @_; > + my $path = "${real_dir}/${file}"; > + if (grep { $_->[1] eq $path } $mounts->@*) { > + PVE::Tools::run_command(['umount', $path]); > + } Could only check it if shooting down the qsd process with `kill -KILL `, but starting the VM again worked flawlessly, thanks! > + unlink $path; > + }, > + ); > +} _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel