From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 997BC1FF15E for ; Mon, 27 Oct 2025 15:43:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A66778B7E; Mon, 27 Oct 2025 15:43:32 +0100 (CET) Mime-Version: 1.0 Date: Mon, 27 Oct 2025 15:42:59 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Proxmox VE development discussion" Cc: "pve-devel" X-Mailer: aerc 0.21.0 References: <20251003150045.3359961-1-a.lauterer@proxmox.com> <20251003150045.3359961-4-a.lauterer@proxmox.com> In-Reply-To: <20251003150045.3359961-4-a.lauterer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761576167955 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v8 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Oct 3, 2025 at 5:00 PM CEST, Aaron Lauterer wrote: > @@ -474,7 +477,7 @@ Ext.define('PVE.qemu.Config', { > lock = rec ? rec.data.value : undefined; > > spice = !!s.data.get('spice'); > - xtermjs = !!s.data.get('serial'); > + xtermjs = PVE.Utils.isSerialDisplay(s.data.get('display')?.data.value.type); > } > > rec = s.data.get('tags'); > @@ -486,6 +489,10 @@ Ext.define('PVE.qemu.Config', { > > var resume = ['prelaunch', 'paused', 'suspended'].indexOf(qmpstatus) !== -1; > > + me.lookup('submenuConsoleBtn')?.loadConsole(xtermjs, 'kvm'); > + > + statusTxt.update({ lock: lock }); > + Might be that I'm just missing something, but why was this moved up compared to v7? I don't think this is related to the rebase? > if (resume || lock === 'suspended') { > startBtn.setVisible(false); > resumeBtn.setVisible(true); _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel