From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 77C0B1FF15C for ; Fri, 3 Oct 2025 16:02:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 795DE4CE2; Fri, 3 Oct 2025 16:02:02 +0200 (CEST) Mime-Version: 1.0 Date: Fri, 03 Oct 2025 16:01:55 +0200 Message-Id: From: "Shan Shaji" Cc: "pve-devel" To: "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20251002151609.41473-1-n.frey@proxmox.com> In-Reply-To: <20251002151609.41473-1-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759500091316 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.129 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager v2 0/2] ui: fix #6209: create snapshots and backups from context menu X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Applied this patch series and tested the changes. Verfied The Following: - Confirmed the right-click context menu now shows both "Take Snapshot" and "Backup now" options. - Clicking on the options show the backup and snapshots dialog. - Took snapshots for VMs and CTs - Ran manual PBS backups for a VM and a CT. - The snapshot window extra curly brace is also not visible anymore. Tested-by: Shan Shaji On Thu Oct 2, 2025 at 5:16 PM CEST, Nicolas Frey wrote: > This patch series adds functionality to take snapshots and create > manual backups of VMs and CTs through the right-click context menu. > > The original feature request [0] only specified the ability to take > snapshots. I added the manual backup shortcut as well, since > navigating through the menu for this action felt unnecessarily > cumbersome when performing just a quick backup. LMK if that is a > useful addition. > > changes since v1, thanks @Fiona Ebner > * clarified commit message > * addressed several issues in the added menu options, namely: > * correctly handle disabled state with async > * fixed negation logic and cleaned up minor nits > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=6209 > > Nicolas Frey (2): > ui: guest snapshot: remove excess '}' at the end of window title > ui: fix #6209: create snapshots and backups from context menu > > www/manager6/lxc/CmdMenu.js | 47 +++++++++++++++++++++++++++++++++ > www/manager6/qemu/CmdMenu.js | 47 +++++++++++++++++++++++++++++++++ > www/manager6/window/Snapshot.js | 2 +- > 3 files changed, 95 insertions(+), 1 deletion(-) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel