From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2F60F1FF17E for ; Thu, 2 Oct 2025 14:15:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A9E8E561; Thu, 2 Oct 2025 14:15:51 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 02 Oct 2025 14:15:16 +0200 Message-Id: Cc: "pve-devel" To: "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20250929093555.86352-1-n.frey@proxmox.com> In-Reply-To: <20250929093555.86352-1-n.frey@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759407293455 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [content.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH pve-storage] fix #6450: add file-checksum endpoint to storage API X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" one comment in-line On Mon Sep 29, 2025 at 11:35 AM CEST, Nicolas Frey wrote: > The storage API endpoint now supports an optional 'checksum' parameter. > If set, the checksum is calculated using one of the hashing algorithms > listed in the enum and returned in the 'checksum' return property. > > Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6450 > > Signed-off-by: Nicolas Frey > --- > src/PVE/API2/Storage/Content.pm | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/src/PVE/API2/Storage/Content.pm b/src/PVE/API2/Storage/Content.pm > index 1fe7303..ea60589 100644 > --- a/src/PVE/API2/Storage/Content.pm > +++ b/src/PVE/API2/Storage/Content.pm > @@ -306,6 +306,12 @@ __PACKAGE__->register_method({ > description => "Volume identifier", > type => 'string', > }, > + checksum => { > + description => 'The algorithm to calculate the checksum of the file.', > + enum => [qw(sha512 sha384 sha256 sha224 sha1 md5)], > + type => 'string', > + optional => 1, > + } > }, > }, > returns => { > @@ -340,6 +346,11 @@ __PACKAGE__->register_method({ > type => 'boolean', > optional => 1, > }, > + checksum => { > + description => 'The checksum of the file.', > + type => 'string', > + optional => 1, > + } > }, > }, > code => sub { > @@ -376,6 +387,11 @@ __PACKAGE__->register_method({ > warn $@ if $@; > } > > + if (exists $param->{checksum}) { > + print "calculating checksum...\n"; > + $entry->{checksum} = PVE::Tools::get_file_hash($param->{checksum}, $path); i've tested this with some not too uncommon disk images such as a 32GB volume that is essentially empty and the api endpoint here just times out. which is not too surprising. i wonder if we can cache the hashes here somehow and calculate them in a worker tasks. i also wonder how this should ideally work for running vm and container images as their checksum could change all the time. maybe we can at least calculate the hashes here for some more static assets such iso etc. ahead of time and only enable this flag for things like that (so isos, container templates, images of vm and container templates etc.) basically things that don't change that much? > + } > + > return $entry; > }, > }); _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel