From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 99A7D1FF191 for ; Tue, 23 Sep 2025 14:11:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 02552D481; Tue, 23 Sep 2025 14:12:15 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 23 Sep 2025 14:12:11 +0200 Message-Id: To: "Thomas Lamprecht" , "Proxmox VE development discussion" From: "Shan Shaji" X-Mailer: aerc 0.20.0 References: <20250923093629.119418-1-s.shaji@proxmox.com> <20250923093629.119418-3-s.shaji@proxmox.com> <21924f8b-a3e6-48ee-acbd-2d4a8787b907@proxmox.com> In-Reply-To: <21924f8b-a3e6-48ee-acbd-2d4a8787b907@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758629518908 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.143 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve_flutter_frontend 2/3] feat: ui: add bottom sheet to change VMs/CTs options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thanks @Thomas for spotting that. I will send a v2 with the fix. On Tue Sep 23, 2025 at 2:03 PM CEST, Thomas Lamprecht wrote: > Am 23.09.25 um 11:37 schrieb Shan Shaji: >> On the options page for VMs and CTs it was easy to change the configs by >> mistake. To avoid add a bottom sheet to show the editable option. >> >> The value will only be updated when the `update` button is pressed. >> >> Signed-off-by: Shan Shaji >> --- >> .../pve_config_switch_form.dart | 54 ++++++ >> lib/widgets/pve_config_list_tile.dart | 176 +++++++++++++++++ >> lib/widgets/pve_lxc_options_widget.dart | 78 +++++--- >> lib/widgets/pve_qemu_options_widget.dart | 177 ++++++++++++------ >> 4 files changed, 400 insertions(+), 85 deletions(-) >> create mode 100644 lib/widgets/pve_config_forms/pve_config_switch_form.dart >> create mode 100644 lib/widgets/pve_config_list_tile.dart >> >> diff --git a/lib/widgets/pve_config_forms/pve_config_switch_form.dart b/lib/widgets/pve_config_forms/pve_config_switch_form.dart >> new file mode 100644 >> index 0000000..61ae014 >> --- /dev/null >> +++ b/lib/widgets/pve_config_forms/pve_config_switch_form.dart >> @@ -0,0 +1,54 @@ >> +import 'package:flutter/material.dart'; >> +import 'package:pve_flutter_frontend/widgets/pve_config_tile.dart'; > > Above does not exist, should probably be the newly added "pve_config_list_tile.dart" file? > I.e.: > > diff --git a/lib/widgets/pve_config_forms/pve_config_switch_form.dart b/lib/widgets/pve_config_forms/pve_config_switch_form.dart > index 61ae014..40bef8c 100644 > --- a/lib/widgets/pve_config_forms/pve_config_switch_form.dart > +++ b/lib/widgets/pve_config_forms/pve_config_switch_form.dart > @@ -1,5 +1,5 @@ > import 'package:flutter/material.dart'; > -import 'package:pve_flutter_frontend/widgets/pve_config_tile.dart'; > +import 'package:pve_flutter_frontend/widgets/pve_config_list_tile.dart'; > > class PveConfigSwitchForm extends StatefulWidget { > const PveConfigSwitchForm({ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel