From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id B47AC1FF16F
	for <inbox@lore.proxmox.com>; Tue,  2 Sep 2025 16:48:15 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 012EB178FC;
	Tue,  2 Sep 2025 16:48:30 +0200 (CEST)
Mime-Version: 1.0
Date: Tue, 02 Sep 2025 16:47:57 +0200
Message-Id: <DCIEAV0FT7MT.2V3T7XBEO217G@proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.20.0
References: <20250902124524.368080-1-m.sandoval@proxmox.com>
 <20250902124524.368080-5-m.sandoval@proxmox.com>
In-Reply-To: <20250902124524.368080-5-m.sandoval@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1756824463276
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.014 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server v2 4/6] log when issuing a
 guest-fsfreeze command
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Tue Sep 2, 2025 at 2:45 PM CEST, Maximiliano Sandoval wrote:
>  These messages appear during replication or snapshots.

nit: would be nice to also document that moving the logging from
PVE::Replication::replicate(...) here now makes the messages appear
at all call sites of __snapshot_freeze(...).

The commit messages indicated to me that it has already been that way
before.

>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/PVE/QemuConfig.pm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm
> index 51593b60..679c3893 100644
> --- a/src/PVE/QemuConfig.pm
> +++ b/src/PVE/QemuConfig.pm
> @@ -310,9 +310,11 @@ sub __snapshot_freeze {
>      my ($class, $vmid, $unfreeze) = @_;
>  
>      if ($unfreeze) {
> +        print "issuing guest agent 'guest-fsfreeze-thaw' command\n";
>          eval { mon_cmd($vmid, "guest-fsfreeze-thaw"); };
>          warn "guest-fsfreeze-thaw problems - $@" if $@;
>      } else {
> +        print "issuing guest agent 'guest-fsfreeze-freeze' command\n";
>          eval { mon_cmd($vmid, "guest-fsfreeze-freeze"); };
>          warn "guest-fsfreeze-freeze problems - $@" if $@;
>      }



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel