From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C817C1FF15E for ; Mon, 1 Sep 2025 15:04:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2AA6E2F0D5; Mon, 1 Sep 2025 15:04:24 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 01 Sep 2025 15:03:49 +0200 Message-Id: To: "Proxmox VE development discussion" Cc: "pve-devel" X-Mailer: aerc 0.20.0 References: <20250829114337.345358-1-m.sandoval@proxmox.com> In-Reply-To: <20250829114337.345358-1-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756731817520 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container/guest-common/qemu-server 0/3] log when freezing or thawing the guest's fs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Aug 29, 2025 at 1:43 PM CEST, Maximiliano Sandoval wrote: > At the moment taking a snapshot without RAM does not log whether there was a freeze/thaw. > > This does not add an extra log line when making a Backup in snapshot mode. > > qemu-server: > > Maximiliano Sandoval (1): > log when issues a guest-fsfreeze command > > src/PVE/QemuConfig.pm | 2 ++ > 1 file changed, 2 insertions(+) > > > pve-container: > > Maximiliano Sandoval (1): > log when freezing/thawing filesystem > > src/PVE/LXC/Config.pm | 2 ++ > 1 file changed, 2 insertions(+) > > > qemu-server: > > Maximiliano Sandoval (1): > replication: remove logging when freezing/thawing > > src/PVE/Replication.pm | 2 -- > 1 file changed, 2 deletions(-) > > > Summary over all repositories: > 3 files changed, 4 insertions(+), 2 deletions(-) for the vm part this looks fine, the new log lines show up in the log for a vm's snapshot without ram, but not with ram or backups: issuing guest-agent 'fs-freeze' command snapshotting 'drive-scsi0' (vms:vm-100-disk-0) issuing guest-agent 'fs-thaw' command TASK OK for a container this now always says: freezing guest filesystem thawing guest filesystem TASK OK however, for backups it looks like this: INFO: starting new backup job: vzdump 101 --remove 0 --mode snapshot --node pve-icon-cleanup --storage local --compress zstd --notification-mode notification-system --notes-template '{{guestname}}' INFO: Starting Backup of VM 101 (lxc) INFO: Backup started at 2025-09-01 14:54:33 INFO: status = running INFO: CT Name: CT101 INFO: including mount point rootfs ('/') in backup INFO: backup mode: snapshot INFO: ionice priority: 7 INFO: create storage snapshot 'vzdump' freezing guest filesystem thawing guest filesystem INFO: creating vzdump archive '/var/lib/vz/dump/vzdump-lxc-101-2025_09_01-14_54_33.tar.zst' INFO: Total bytes written: 697968640 (666MiB, 215MiB/s) INFO: archive file size: 201MB INFO: adding notes to backup INFO: cleanup temporary 'vzdump' snapshot INFO: Finished Backup of VM 101 (00:00:03) INFO: Backup finished at 2025-09-01 14:54:36 INFO: Backup job finished successfully INFO: notified via target `mail-to-root` TASK OK imo it would be nicer to pass down the log function so that it can log those two lines with the proper log level (`INFO`) here too. however, i am not sure if that is particularly useful for containers in general. we don't expose a setting for turning freezing/thawing here to users. the mechanism is different in my understanding too, as we don't need to rely on a guest agent for containers anyway. possibly the patch for pve-container can just be dropped? other than that: Tested-by: Shannon Sterz Reviewed-by: Shannon Sterz _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel