From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6C44C1FF186 for ; Fri, 29 Aug 2025 14:43:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A88992E1B6; Fri, 29 Aug 2025 14:43:22 +0200 (CEST) Date: Fri, 29 Aug 2025 14:43:19 +0200 Message-Id: Cc: "pve-devel" From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Proxmox VE development discussion" Mime-Version: 1.0 X-Mailer: aerc 0.20.1 References: <20250821143705.256562-1-d.kral@proxmox.com> <20250821143705.256562-16-d.kral@proxmox.com> In-Reply-To: <20250821143705.256562-16-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756471391180 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [manager.pm] Subject: Re: [pve-devel] [PATCH ha-manager 15/18] manager: move group migration cooldown variable into helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu Aug 21, 2025 at 4:35 PM CEST, Daniel Kral wrote: > The variable is only used in the try_persistent_group_migration(...) > helper. While at it, add a comment and change the name to make its > meaning clearer. > > Signed-off-by: Daniel Kral > --- > src/PVE/HA/Manager.pm | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm > index 14a20c5b..8d600a7d 100644 > --- a/src/PVE/HA/Manager.pm > +++ b/src/PVE/HA/Manager.pm > @@ -41,8 +41,6 @@ use PVE::HA::Usage::Static; > # patches for changing above, as that set is mostly sensible and should be easy to remember once > # spending a bit time in the HA code base. > > -my $group_migration_cooldown = 6; > - > sub new { > my ($this, $haenv) = @_; > > @@ -640,13 +638,16 @@ my $migrate_group_persistently = sub { > sub try_persistent_group_migration { > my ($self) = @_; > > + # rounds to wait until next ha group migration try > + my $group_migration_cooldown_round = 6; nit: I think something like $group_migration_cooldown_rounds or $group_migration_cooldown_round_count would be better. > + > my ($haenv, $ns, $ss) = ($self->{haenv}, $self->{ns}, $self->{ss}); > > return if $have_groups_been_migrated->($haenv); > > $self->{group_migration_round}--; > return if $self->{group_migration_round} > 0; > - $self->{group_migration_round} = $group_migration_cooldown; > + $self->{group_migration_round} = $group_migration_cooldown_round; > > $haenv->log('notice', "start ha group migration..."); > > @@ -656,8 +657,8 @@ sub try_persistent_group_migration { > $haenv->log('err', "ha groups migration failed"); > $haenv->log( > 'notice', > - "retry ha groups migration in $group_migration_cooldown rounds (~ " > - . $group_migration_cooldown * 10 > + "retry ha groups migration in $group_migration_cooldown_round rounds (~ " > + . $group_migration_cooldown_round * 10 > . " seconds)", > ); > } _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel