From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8E54B1FF185 for ; Mon, 4 Aug 2025 14:09:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 498D41FCFF; Mon, 4 Aug 2025 14:10:43 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 04 Aug 2025 14:10:38 +0200 Message-Id: To: "Fiona Ebner" , "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20250804105024.117020-1-s.sterz@proxmox.com> <60d95852-a9a0-46bf-8ee6-787457a56dc0@proxmox.com> In-Reply-To: <60d95852-a9a0-46bf-8ee6-787457a56dc0@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754309420679 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] fix #6599: ui: use font-awesome instead of png icons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon Aug 4, 2025 at 1:48 PM CEST, Fiona Ebner wrote: > Am 04.08.25 um 12:50 PM schrieb Shannon Sterz: >> previously we used custom png rendered icons for guests and storages >> in the add menu of a pool, as well as for mountpoints for containers. >> these appeared blurry on high resolution displays and since they were >> just the same as the font-awesome icons anyway, use those directly. >> the ui already loads font-awesome regardless, so there are no >> down-sides here. >> >> Signed-off-by: Shannon Sterz >> --- >> www/manager6/grid/PoolMembers.js | 4 ++-- >> www/manager6/lxc/Resources.js | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js >> index f025a1380..83046ee0e 100644 >> --- a/www/manager6/grid/PoolMembers.js >> +++ b/www/manager6/grid/PoolMembers.js >> @@ -243,7 +243,7 @@ Ext.define('PVE.grid.PoolMembers', { >> items: [ >> { >> text: gettext('Virtual Machine'), >> - iconCls: 'pve-itype-icon-qemu', >> + iconCls: 'fa fa-desktop', >> handler: function () { >> var win = Ext.create('PVE.pool.AddVM', { pool: me.pool }); >> win.on('destroy', reload); >> @@ -252,7 +252,7 @@ Ext.define('PVE.grid.PoolMembers', { >> }, >> { >> text: gettext('Storage'), >> - iconCls: 'pve-itype-icon-storage', >> + iconCls: 'fa fa-hdd-o', >> handler: function () { >> var win = Ext.create('PVE.pool.AddStorage', { pool: me.pool }); >> win.on('destroy', reload); >> diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js >> index 9f6df3a58..3defb8003 100644 >> --- a/www/manager6/lxc/Resources.js >> +++ b/www/manager6/lxc/Resources.js >> @@ -128,7 +128,7 @@ Ext.define('PVE.lxc.RessourceView', { >> rows[confid] = { >> group: group, >> order: i, >> - tdCls: 'pve-itype-icon-storage', >> + iconCls: 'hdd-o', > > This changes from 'tdCls' to 'iconCls' and does not use 'fa fa-hdd-o' > like above. Is that intentional? yes, this is to keep it in-line with other iconCls definitions here. see for example the definition for rootfs (which uses the exact same icon). note that these get rendered differently, even though both are called `iconCls`. the one in the resources table outputs a proper `` element with the appropriate classes set already (here Ext.js seems to expand `hdd-o` to `fa fa-hdd-o` automatically). the other just adds the classes directly to the menu item in the pool's add menu. so it needs the `fa fa-desktop` and `fa fa-hdd-o` classes, in order for the icons to be set via pseudo elements properly. >> editor: mpeditor, >> header: header, >> renderer: Ext.htmlEncode, > > Can we get rid of the related CCS classes and PNG images after this change? i grepped over our repos and it seems that these are the only places that make use of these classes. so yes removing them now *should* be safe. let me know if you want a follow up for that. although, if we go down this path i'd suggest we remove all `pve-itype-icon-*` classes with font-awesome equivalents. which would be a bit more extensive and touch all our current ext.js front-end repos. however, this patch would still be the same, the follow-up would just be additional clean-up. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel