From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9AFA81FF185 for ; Mon, 4 Aug 2025 11:28:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 49BCC1C67C; Mon, 4 Aug 2025 11:29:53 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 04 Aug 2025 11:29:19 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox VE development discussion" , X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250804080604.118202-1-l.wagner@proxmox.com> In-Reply-To: <20250804080604.118202-1-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754299741264 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox] http: use request method from provided param instead of unconditional POST X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Wolfgang Bumiller Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon Aug 4, 2025 at 10:06 AM CEST, Lukas Wagner wrote: > This fixes the "bad uri: POST is missing scheme" error that appeared > when using the webhook notification targets. > > Fixes: a0dc071ee14 ("http: update to ureq3") > Signed-off-by: Lukas Wagner > --- > proxmox-http/src/client/sync.rs | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/proxmox-http/src/client/sync.rs b/proxmox-http/src/client/sync.rs > index b809ee38..fe87a0cf 100644 > --- a/proxmox-http/src/client/sync.rs > +++ b/proxmox-http/src/client/sync.rs > @@ -127,7 +127,9 @@ impl HttpClient for Client { > let (parts, body) = request.into_parts(); > > let agent = self.agent()?; > - let mut req = http::Request::post(parts.method.as_str()); > + let mut req = http::Request::builder() > + .method(parts.method.as_str()) > + .uri(parts.uri); > > for header in parts.headers.keys() { > for value in parts.headers.get_all(header) { > @@ -182,7 +184,9 @@ impl HttpClient<&[u8], Vec> for Client { > let (parts, body) = request.into_parts(); > > let agent = self.agent()?; > - let mut req = http::Request::post(parts.method.as_str()); > + let mut req = http::Request::builder() > + .method(parts.method.as_str()) > + .uri(parts.uri); > > for header in parts.headers.keys() { > for value in parts.headers.get_all(header) { > @@ -240,7 +244,9 @@ impl HttpClient, Box> for Client { > let (parts, body) = request.into_parts(); > > let agent = self.agent()?; > - let mut req = http::Request::post(parts.method.as_str()); > + let mut req = http::Request::builder() > + .method(parts.method.as_str()) > + .uri(parts.uri); > > for header in parts.headers.keys() { > for value in parts.headers.get_all(header) { Forgot to add to the patch notes: In addition to proxmox-backup and libpve-rs-perl, please also bump/rebuild proxmox-mail-forward - that one is always easy to overlook for any notification-related fixes! Thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel