From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 698841FF180 for ; Fri, 1 Aug 2025 15:03:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F52B19A3F; Fri, 1 Aug 2025 15:05:13 +0200 (CEST) Mime-Version: 1.0 Date: Fri, 01 Aug 2025 15:04:39 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox VE development discussion" , "Thomas Lamprecht" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250801095431.117317-1-l.wagner@proxmox.com> <175405274372.2432529.8239150314582136063.b4-ty@proxmox.com> In-Reply-To: <175405274372.2432529.8239150314582136063.b4-ty@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754053465443 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Aug 1, 2025 at 2:52 PM CEST, Thomas Lamprecht wrote: > Applied, thanks! > > But can you please add a cover-letter for any actual patch series (i.e., not > just a single patch), as that provides some value even if it's empty, as it > makes it very clear if trailers like T-b or R-b are intended for the full > series or just a single patch out of it. b4 also uses the same logic to > determine for which commits to apply the R-b and T-b too, so here I had to > manually add Maximiliano's R-b and T-b to patch 2 to 5, as from b4's POV they > where only supplied for patch 1/5. > > A diffstat over all patches is a side benefit, a short sentence as overview > might be nice too, but for things like these here it can be even fine to not > have that. > > Not a big thing, but would make my (and others using b4) life a bit easier and > better ensure that tests and reviews get encoded into git, providing some > recognition of that important work. > Okay, will keep this in mind for the future. Thanks for the hint and explanation! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel