From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 12ECC1FF180 for ; Fri, 1 Aug 2025 14:53:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CB77719685; Fri, 1 Aug 2025 14:55:14 +0200 (CEST) Mime-Version: 1.0 Date: Fri, 01 Aug 2025 14:55:12 +0200 Message-Id: To: "Proxmox VE development discussion" Cc: "pve-devel" From: "Lukas Wagner" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250801095431.117317-1-l.wagner@proxmox.com> In-Reply-To: <20250801095431.117317-1-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754052898313 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Aug 1, 2025 at 11:54 AM CEST, Lukas Wagner wrote: > Otherwise we leak the memory that was already allocated for `filename`. > > Signed-off-by: Lukas Wagner > --- > src/pmxcfs/status.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c > index a00e793..886d0bd 100644 > --- a/src/pmxcfs/status.c > +++ b/src/pmxcfs/status.c > @@ -1369,6 +1369,8 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) { > } else if (g_file_test(filename_pve2, G_FILE_TEST_EXISTS)) { > // old file exists, use it > use_pve2_file = 1; > + > + g_free(filename); > filename = g_strdup_printf("%s", filename_pve2); > } else { > // neither file exists, check for directories to decide and create file FWIW, did a quick rebuild of pve-cluster with -fsanitize=address set in the CFLAGS/LDFLAGS. While I might not have hit all possible code paths during my test run, at least the "main" one with the new RRD format came back without any reported leaks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel