From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7D9571FF180 for ; Fri, 1 Aug 2025 11:27:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4847114B08; Fri, 1 Aug 2025 11:29:18 +0200 (CEST) Mime-Version: 1.0 Date: Fri, 01 Aug 2025 11:29:14 +0200 Message-Id: To: "Shannon Sterz" , X-Mailer: aerc 0.20.0 References: <20250801091336.68133-1-s.sterz@proxmox.com> In-Reply-To: <20250801091336.68133-1-s.sterz@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754040541335 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] pve8to9: don't report already migrated files as needing to be migrated X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri Aug 1, 2025 at 11:13 AM CEST, Shannon Sterz wrote: > the find command previously also found the already migrated rrd files > under `pve-{vm,node,storage}-9.0` and reported them as needing to > migrate them. the provided command to would of course not migrate them > so the warning persisted even after the command was run. > > limit the find command to the old `pve2-` prefixed folders to prevent > that. > > Signed-off-by: Shannon Sterz > --- > PVE/CLI/pve8to9.pm | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm > index 4d61cd831..834432b95 100644 > --- a/PVE/CLI/pve8to9.pm > +++ b/PVE/CLI/pve8to9.pm > @@ -1880,7 +1880,17 @@ sub check_rrd_migration { > }; > eval { > run_command( > - ['find', '/var/lib/rrdcached/db', '-type', 'f', '!', '-name', '*.old'], > + [ > + 'find', > + '/var/lib/rrdcached/db', > + '-path', > + '*pve2-*', > + '-type', > + 'f', > + '!', > + '-name', > + '*.old', > + ], > outfunc => $count_occurences, > noerr => 1, > ); I guess this should have had the following added: Reported-by: Friedrich Weber Reported-by: Daniel Herzig as both have reported this issue independently from me _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel