From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 19A111FF165 for ; Thu, 31 Jul 2025 08:49:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 229D432E82; Thu, 31 Jul 2025 08:51:20 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 31 Jul 2025 08:51:14 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox VE development discussion" , "Thomas Lamprecht" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250726010626.1496866-1-a.lauterer@proxmox.com> <20250726010626.1496866-28-a.lauterer@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753944662080 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v4 2/4] vmstatus: add memhost for host view of vm mem consumption X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu Jul 31, 2025 at 5:37 AM CEST, Thomas Lamprecht wrote: > Am 29.07.25 um 14:50 schrieb Lukas Wagner: >> On Sat Jul 26, 2025 at 3:06 AM CEST, Aaron Lauterer wrote: >>> + my $fh = IO::File->new("/sys/fs/cgroup/qemu.slice/${vmid}.scope/cgroup.procs", "r"); >>> + if ($fh) { >>> + while (my $childPid = <$fh>) { >>> + chomp($childPid); >> >> nit: should be snake_case > > +1 and go into it's own method, I moved it in a follow-up > >> >>> + open(my $SMAPS_FH, '<', "/proc/$childPid/smaps_rollup") >>> + or die "failed to open PSS memory-stat from process - $!\n"; >>> + >>> + while (my $line = <$SMAPS_FH>) { >>> + if ($line =~ m/^Pss:\s+([0-9]+) kB$/) { >>> + $d->{memhost} = $d->{memhost} + int($1) * 1024; >> >> Why do you sum up $d->{memhost} with the thing you just read from /proc? >> As far as I can tell memhost should always be zero at this point.... > > it's a += and there are two loops, basically it sums up all Pss stats for > every process in a cgroup to get a somewhat correct total memory consumption > of that cgroup. I guess I must have missed that second loop, my bad. Thanks for the clarification! > >> >> >>> + last; >> >> ... and also you break here from the loop, so even if there were two Pss >> lines, you wouldn't add them up. >> >> Am I missing something? :) > > This is smaps_rollup, not smaps, i.e. the former is a a summed up variant > of all separate mappings from the latter, so there is always only one Pss > entry in there. > > See (need to search twice for "smaps_rollup", there is no better link anchor > in the vicinity): > > https://docs.kernel.org/filesystems/proc.html#process-specific-subdirectories > Thanks, I'll have a look! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel