From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8C69E1FF16B for ; Tue, 29 Jul 2025 11:49:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A400BCB4D; Tue, 29 Jul 2025 11:50:24 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 29 Jul 2025 11:49:40 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox VE development discussion" , "Thomas Lamprecht" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250726010626.1496866-1-a.lauterer@proxmox.com> <20250726010626.1496866-4-a.lauterer@proxmox.com> <45986eca-3b6f-4e79-9e67-7ada6fd76be5@proxmox.com> In-Reply-To: <45986eca-3b6f-4e79-9e67-7ada6fd76be5@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753782571074 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-rrd-migration-tool v4 3/3] add debian packaging X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue Jul 29, 2025 at 11:29 AM CEST, Thomas Lamprecht wrote: > Am 28.07.25 um 16:36 schrieb Lukas Wagner: >>> diff --git a/debian/links b/debian/links >>> new file mode 100644 >>> index 0000000..9e59b57 >>> --- /dev/null >>> +++ b/debian/links >>> @@ -0,0 +1 @@ >>> +usr/libexec/proxmox/proxmox-rrd-migration-tool usr/bin/proxmox-rrd-migration-tool >> As far as I understand this is a tool that should be called directly by >> a user, right? In that case I'd not add the symlink but alter the >> Makefile so that it installs it to /usr/bin/ right away. > > It actually shouldn't, the migration should be handled automatically and > the tool only called manually in the edge case, in which providing the full > path (e.g., in the respective 8to9 check output) is enough. Ah yeah, wrote this comment before actually looking into the pve-manager patches, missed that it is supposed to be called by d/postinst. > > So while you're definitively right in that this way is not gaining us > anything (good catch!), I'd rather just drop the symnlink in /usr/bin and > keep it only in libexec. Agreed, in this case I'd also just drop the symlink. Thanks for the clarification! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel