From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 889831FF16B for ; Tue, 29 Jul 2025 10:15:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 469C0A230; Tue, 29 Jul 2025 10:16:31 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 29 Jul 2025 10:15:57 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox VE development discussion" , "Aaron Lauterer" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250726010626.1496866-1-a.lauterer@proxmox.com> <20250726010626.1496866-25-a.lauterer@proxmox.com> In-Reply-To: <20250726010626.1496866-25-a.lauterer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753776948477 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager stabe-8+master v4 15/15] pve8to9: add checkfs for RRD migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Sat Jul 26, 2025 at 3:06 AM CEST, Aaron Lauterer wrote: > +sub check_rrd_migration { > + if (-e "/var/lib/rrdcached/db/pve-node-9.0") { > + log_info("Check post RRD migration situation..."); > + > + my $count = 0; > + my $count_occurences = sub { > + $count++; > + }; > + eval { > + run_command( > + ['find /var/lib/rrdcached/db -type f ! -name "*.foo"'], Shouldn't this be "*.old"? > + outfunc => $count_occurences, > + noerr => 1, > + ); > + }; > + > + if ($count) { > + log_warn("Found '$count' RRD files that have not yet been migrated to the new schema." > + . " Please run the following command manually:\n" > + . "proxmox-rrd-migration-tool --migrate\n"); > + } > + > + } else { > + log_info("Check space requirements for RRD migration..."); > + # multiplier values taken from KiB sizes of old and new RRD files > + my $rrd_dirs = { > + nodes => { > + path => "/var/lib/rrdcached/db/pve2-node", > + multiplier => 18.1, > + }, > + guests => { > + path => "/var/lib/rrdcached/db/pve2-vm", > + multiplier => 20.2, > + }, > + storage => { > + path => "/var/lib/rrdcached/db/pve2-storage", > + multiplier => 11.14, > + }, > + }; > + > + my $size_buffer = 1024 * 1024 * 1024; # at least one GiB of free space should be calculated in Could be worth defining some GIGABYTE constant... > + my $total_size_estimate = 0; > + for my $type (keys %$rrd_dirs) { > + my $size = PVE::Tools::du($rrd_dirs->{$type}->{path}); > + $total_size_estimate = > + $total_size_estimate + ($size * $rrd_dirs->{$type}->{multiplier}); > + } > + my $root_free = PVE::Tools::df('/', 10); > + > + if (($total_size_estimate + $size_buffer) >= $root_free->{avail}) { > + my $estimate_gib = sprintf("%.2f", $total_size_estimate / 1024 / 1024 / 1024); > + my $free_gib = sprintf("%.2f", $root_free->{avail} / 1024 / 1024 / 1024); ...that you can also use here as a divider. > + log_fail("Not enough free space to migrate existing RRD files to the new format!\n" > + . "Migrating the current RRD files is expected to consume about ${estimate_gib} GiB plus 1 GiB of safety." > + . " But there is currently only ${free_gib} GiB space on the root file system available.\n" > + ); > + } > + } > +} > + > sub check_virtual_guests { > print_header("VIRTUAL GUEST CHECKS"); > > @@ -1882,6 +1943,7 @@ sub check_misc { > check_legacy_notification_sections(); > check_legacy_backup_job_options(); > check_lvm_autoactivation(); > + check_rrd_migration(); > } > > my sub colored_if { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel