From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A6B601FF17C for ; Wed, 23 Jul 2025 14:59:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A36D711F6B; Wed, 23 Jul 2025 15:00:35 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 23 Jul 2025 15:00:32 +0200 Message-Id: Cc: "pve-devel" To: "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20250613131125.354560-1-m.sandoval@proxmox.com> In-Reply-To: <20250613131125.354560-1-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753275622468 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage v2] fix #5181: pbs: store and read passwords as unicode X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" -->8 snip 8<-- > > - PVE::Tools::file_set_contents($pwfile, "$password\n"); > + PVE::Tools::file_set_contents($pwfile, "$password\n", undef, 1); i know this is pre-existing, but i'd feel more comfortable forcing the permissions here rather than depending on the default behaviour. this is a password file after all, being explicit doesn't hurt in my opinion. > } > > sub pbs_delete_password { > @@ -109,7 +110,9 @@ sub pbs_get_password { > > my $pwfile = pbs_password_file_name($scfg, $storeid); > > - return PVE::Tools::file_read_firstline($pwfile); > + my $contents = PVE::Tools::file_read_firstline($pwfile); > + > + return eval { decode('UTF-8', $contents, 1) } // $contents; > } > > sub pbs_encryption_key_file_name { other than the one comment above, consider this: Reviewed-by: Shannon Sterz Tested-by: Shannon Sterz _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel