From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 648A61FF183 for ; Wed, 16 Jul 2025 09:35:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 62A818E2A; Wed, 16 Jul 2025 09:36:20 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 16 Jul 2025 09:35:46 +0200 Message-Id: To: "Dominik Csapak" , "Proxmox VE development discussion" From: "Shan Shaji" X-Mailer: aerc 0.14.0 References: <20250710084446.8247-1-s.shaji@proxmox.com> In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.245 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] chore: ios: update bundle identifier and display name X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Hey, I changed the bundle identifier to match with the bundle identifier that thomas created in the apple developer console. Also the same identifier is used inside the app store connect to create the app record. On Tue Jul 15, 2025 at 1:28 PM CEST, Dominik Csapak wrote: > On 7/10/25 10:44, Shan Shaji wrote: > > For iOS, the bundle identifier and display name were incorrect. The > > issue was fixed by updating the bundle identifier to > > `com.proxmox.proxmox-ve-companion` and the display name to "Proxmox VE". > > ok i understand the name change, but what exactly was wrong with > > 'com.proxmox.pveFlutterFrontend' ? > > are there any guidelines or rules in the app store that would prevent us from using that? > > I'm not saying we can't change this, but it would be good to record the reason at least... I will create a new patch with the reason of why it was changed. > Aside from that the patch looks good to me: > > Reviewed-by: Dominik Csapak > > side note: I'd like to have a testbed where i could test ios changes before i start applying > things... _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel