From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 7A00B1FF0C0 for ; Wed, 18 Nov 2026 10:29:26 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 45CC321672; Wed, 18 Nov 2026 10:29:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l/b1V1jVd1dZ+VFlcMBMeMjfuwdDYk+Lsc0hmDV6+04BkfiOg56tgR8Tmu8hvTWIIa75oT/v8Z6snbO8PnuPmDcVd/PDZZXAph7ek4dHU68kWknDLExdt1kCy/hEgAQRCwmgiOq46OVXP7XZIXN0/vxahAiJpBBIhoo88LC0453QezfjOAaFccMV8agTdWyo2OPF9hrhmcI9fAKd2D/JIcARUilZ6exUzZHzDxgOirLf6p18KiQ36nr6jBnYuX4XcXwt8FqliYH8GVcUnNU+scrQmOybuRMPH1hPW1Al79xBiuQJ0GqK2bR4qfaXrm6OcfGe/CJM4YNizNBNN+ndmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=19zYDfPuvJvn2NMh43VohIDJU3KDpzCACsM1une1njg=; b=XwQy7bLiniyW6aTzYffhMee30SqbwNthk3Ejsfzs3CMN1tismsOroVLO4l1BlJc4Wh7UIvXdc8JR/+KEnizfqJOlXvuw9xZS3HRXN10zg3RcflnaEPAd9Id6nLVZyEZ2a4AUg8JieAI/G1MpygG5G8/a4DTpwowM+t1YOaFQ/nU7woHkUmPUfmEclDodYImpHklB/B1/p8O6gqgL3j4vsG5R/tBo3SEyFRNx9P8zZCG2nh/cvVEI6X1G+SUhSBS+L6+2kauulZ7jdcI40FMOeYYJ25Y+KKyQB5X3jufVYLouOdju7T63typSaxEWfbTrSednnc8aOGKT9ChnXUB+bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cyber.gent; dmarc=pass action=none header.from=cyber.gent; dkim=pass header.d=cyber.gent; arc=none From: Yvan Janssens To: Dominik Csapak , "pve-devel@lists.proxmox.com" Subject: Re: [PATCH pve-cluster] pmxcfs: check_memdb: accept the big-endian index checksum Thread-Topic: [PATCH pve-cluster] pmxcfs: check_memdb: accept the big-endian index checksum Thread-Index: AQHddzxCGbTMQkk+e02lzkMTvzkeS7czjjSAgAAAN6I= Date: Wed, 18 Nov 2026 09:29:17 +0000 Message-ID: References: <20261118090735.71816-1-yvanj@cyber.gent> <84706f35-a2f7-4d8d-a4f8-6dceb86d416d@proxmox.com> In-Reply-To: <84706f35-a2f7-4d8d-a4f8-6dceb86d416d@proxmox.com> Accept-Language: en-BE, en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-reactions: allow authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cyber.gent; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBAP193MB0876:EE_|DB8P193MB0661:EE_ x-ms-office365-filtering-correlation-id: 4cdac6c8-040a-4fc2-2baa-08df45566b3e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|23010399003|1800799024|10070799003|18002099003|22082099003|261009223027099003|13003099007|8096899003|4143699003|56012099006|261102123227099003|261028144727099003|261026140227099003|261026121527099003|261021121427099003|261021123027099003|261022105027099003|261022075727099003|261022115727099003|38070700021|10067099003|7055299009; x-microsoft-antispam-message-info: 7rQ2uTH3j/y84BrfQoJzGod7hGVApakaRZm+iF7v3ix1rWxUlHR413JTURJ1FLN+lsM29QLKFAT4rDDMVnUNVOV3h00IcaUqg7u9WNW6IklT4gxDvje2REWEu/UzjnuocBu957tAWTwuHneNCKP1tZel5HPhPcHEikOIKihwglAqnKuPnuX5yH5J0erl35eqo/XtW8LaYw0v/0rzjLaeHoS868pQuqKAPmIiVPXr1q2X2J+S5sR+V1/xTUKEgaLPCElpzbUEN9W1a92RSJ33HzKIHM1dfQC+gLXChvGyMOGv/XOVNv8dUvquWbgVC7XNezwV0wnhoUOEhoiRF6pQvWNjSBaQbAKI7b06sEAeM6Fmn/hW+Y5bwK97KOMNHjvsHuxJt1oJTAxJYUKQjlovHwB36i+BxRfLnjRblYsAvFbd0dVgPDlAmxFGiblZjVsmEOkRRydAd++OvWYE4At3eaE5tb71e/5BTxrscsZPIdzomPJvpN4GiNKLZDKrlwC8bqibGLnSzTqtW7meQ3ei0t9MRvwMZ1t1DW+GAuZWdjODoa1DyzUUYHlsnNmqfvPawUHzgfKjUdLoiY76HJw14OnKyiCh0QlBgeAdA8JCp55IlqmWvpu7VlGqRuOkZ0SjLIrTaNXQq73QaqXgDJmAreAi2ckh4rmveAbJttjyDLjxY600N0Ca3vnKwIP9IGw3+8X7ODVbf+QVhcgci4ox8A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBAP193MB0876.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(23010399003)(1800799024)(10070799003)(18002099003)(22082099003)(261009223027099003)(13003099007)(8096899003)(4143699003)(56012099006)(261102123227099003)(261028144727099003)(261026140227099003)(261026121527099003)(261021121427099003)(261021123027099003)(261022105027099003)(261022075727099003)(261022115727099003)(38070700021)(10067099003)(7055299009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?9RPDmjec0Bb8L5vvNjJoH2KgQ4M+CVI2Q1rvbK51RlVpgHG9pcwurhrF?= =?Windows-1252?Q?3jNyfF0gjD7zSIbm4pYFpnG8akhqDRSgiM2hjE1alXf/vvjNGY4JtmU5?= =?Windows-1252?Q?gnOAuXeqavRGUZ2Dwka4tke6mCpcBZAjGU7MJCothdTI/wBQPymwxL8l?= =?Windows-1252?Q?eA+Ev4aHsOXsZcwHQk/IAh35ivQxN55wQ5XKV8yqCP4A3NtKM97XmFr+?= =?Windows-1252?Q?1pwAfng4arSYP6L5+BpK4HdHFd2PWEsG4uVHPxp1DEJ937y4BNkLrvqp?= =?Windows-1252?Q?YGtv99FdsZGkoy0WHiZxUut5oYT4wvUNXsLxF/FrzzoJPHkWOcUI41jI?= =?Windows-1252?Q?Z5idcL0K7jyF0D5aPF8j9RHuCIu2w3f7UNuFjk4wyuMFO1QGBwHpwccH?= =?Windows-1252?Q?8fykkXIFhxl4aRxYN1L1o2rThwvygFCtoXf9PfeP/mufL5/C0ENScSjD?= =?Windows-1252?Q?v1qGCvx0nEgtcpJAKIK7AZXWZsPUU3zsYZ1Uc4JxPhnwrJPyiK9sH3GA?= =?Windows-1252?Q?oIbNqfrDUTpNfn/JycmABg+D8WI04kMxojUKu3XolxudXkYM4fuNHA2Y?= =?Windows-1252?Q?rtD6Nz0ggzfiQVwlmqndHWreFqAyN9FI/xc3OZE1q+JcHnzEvHEUvs9M?= =?Windows-1252?Q?h/psHa4bukseE7ZxHuVkW8rqhnFfipe03u/130HVO07IjOSwfdbKa4mT?= =?Windows-1252?Q?M7pusLQTLvjwMD8e1bHLskKo1DWQzcpBl3e2rfwjvFtLllpONjP5U99d?= =?Windows-1252?Q?HR7vphhifLf72lbTKPv/bo2cipNxdLRe9fiXyCdBYxihnvxBajkwc9JF?= =?Windows-1252?Q?tmhJsflKQuXSLXx4UbmFIkeRVp+vzEeF8zGcMhcrLlhQt0/90HH9aRc/?= =?Windows-1252?Q?BAeMB1epmoNjHgd7SKZGClyb5ZsGi11Xenx6xNrrXROL8L5qlN/0v8/W?= =?Windows-1252?Q?JvHsJQCOSS3E62b5Eivj+rCC8uLamj65nAPbNOHMXfR4n/B93MZd+j5z?= =?Windows-1252?Q?mSjKtDaSFDzJdiPD2cxsXKVrcJQaxdJnePyug5IQMt1wv8gWYAU+ZT5D?= =?Windows-1252?Q?7IUPjEDhIKOh7A/wja25tS/ZCkveat9joaGeb/1myXGuCUo/l/lQoYbN?= =?Windows-1252?Q?ihtQ8UDtx6gTyFGk0Cs0TH/5T/B6Y8e7y5KlIIDDfyZrO1B1XLdODW8/?= =?Windows-1252?Q?g+f77sMW/ZDaENnz+peNhwVJauqVIRUSSYdGy88x/0sYy4KHfyvFVH9O?= =?Windows-1252?Q?v6et2kv7FgTCImjErFUqL7Yg9G8l7fLYjJm63yP/HB5c182Cb3cZ3r9q?= =?Windows-1252?Q?n4IzYVJWDP2+PuyPfLFZ9GltDOWWNPsuNIYcLdRGoSp+VFpjU0SUHJN6?= =?Windows-1252?Q?BxU95Qjd9fU2VkBALeTGNW8fSGsSIJ9qtG7wQd9ihLXeVNJh/GVQXQNe?= =?Windows-1252?Q?jqYRuH0Ks+XnScvAQ7XOwJ+yF/1cMdYmfGU7uvWEcpCfSFyUiVqRLKHR?= =?Windows-1252?Q?2KZmu4k3HKWErU6SfvpoMdUB5VgKv+3AwJaJBC+e9CzvNGaf1jjJK7OQ?= =?Windows-1252?Q?oY/FZb2wxaVC6IN0D501ztePdvTKUiqcd38tji5VBXrON6fIjnNV54ig?= =?Windows-1252?Q?5aceMbuoa4vJDUzaIavCM7x9BlnHHWDzRrQk3494ZuzW20kpDaE2H2+w?= =?Windows-1252?Q?nrfFetjPF5u+Kr3L9RGNjG29+CgotY59TpXOThRq2cbNdPoboCvDA+L/?= =?Windows-1252?Q?EcvR8y6zLnpGcVQZTtBVhWEysrOEh+rfXnjk3POkH2wboy/aTQDMA65v?= =?Windows-1252?Q?lyteGMpCm66wHdRAeKKKldNe43E0GIT9jkJyHFg3r57gSDagk6k/G1Pt?= =?Windows-1252?Q?jdMJlu2t+QMb8RLkVyz7xn7feszgzAqd2sU=3D?= MIME-Version: 1.0 X-OriginatorOrg: cyber.gent X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBAP193MB0876.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 4cdac6c8-040a-4fc2-2baa-08df45566b3e X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2026 09:29:17.8111 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d5a0a0d6-18b4-44e3-8e5e-e5dbe37f9ee2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1fByyROgXuduDX6gaf9iZwXD2hrqp8NeEjs6nZbHtXiO9fdv60Tp2zRfBbUhQEgCXiQNnVpQR9ArUlNWQIDL2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8P193MB0661 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.094 Adjusted score from AWL reputation of From: address DMARC_PASS -0.1 DMARC pass policy GB_MSAUTHSOURCE_EUROPE 0.01 Mail authenticated via Microsoft Europe (EURP) datacenter HTML_MESSAGE 0.001 HTML included in message KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6JRDBRXPOMUB4TYPXD42RNDYN6HQRUSU X-Message-ID-Hash: 6JRDBRXPOMUB4TYPXD42RNDYN6HQRUSU X-MailFrom: yvanj@cyber.gent X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="Windows-1252" X-Content-Filtered-By: Mailman/MimeDel 3.3.10 CC: Thomas Lamprecht X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Dominik, A CLA should be in place. Re: use case, I=92m trying to bring up Proxmox on s390x here for myself. For each change, I=92m trying to make a judgement call to see if they would= benefit others - submitting the patches for the FICON, OSA Express network= ing and zIPL bootloader will probably not make sense and add additional blo= at for you to maintain, but eg endianness bugs and /proc/cpuinfo patching d= id sound useful. The current state here is that LXD containers work, and that Linux under KV= M also works. Support for z/OS, z/VM, and VSEn would need more work because= that would require managing CKD volumes as opposed to flat disk images for= storage. /y ________________________________ From: Dominik Csapak Date: Wednesday, 18 November 2026 at 10:22 To: Yvan Janssens ; pve-devel@lists.proxmox.com Cc: Thomas Lamprecht Subject: Re: [PATCH pve-cluster] pmxcfs: check_memdb: accept the big-endian= index checksum Hi, just wanted to ask: Is there a specific use case you have to port pve on s390x ? I don't think we want to support s390x currently so adding s390x specific code won't probably come in soon (please correct me if i'm wrong @thomas) I guess changes such as these *could* be integrated since they're not special for s390x, but I don't think there are many big-endian systems left... In any case, did you see our developer docs: https://pve.proxmox.com/wiki/Developer_Documentation especially the part about the signed CLA (since i didn't found any patches prior to this on our mailing list) On 11/18/26 10:07 AM, Yvan Janssens wrote: > The memdb index and its per-entry digests are built from host-endian > integers, so the checksum hard-coded in test_indextest1 only matches on > little-endian hosts, and the test fails on every big-endian one (for > example s390x and big-endian ppc64). > > Add the big-endian checksum. On s390x, converting all integers to > little-endian before hashing reproduces the existing checksum, so both > values describe the same index. As the index has only fixed-width > fields, the big-endian value holds for any big-endian host. > > Signed-off-by: Yvan Janssens > --- > src/pmxcfs/check_memdb.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/src/pmxcfs/check_memdb.c b/src/pmxcfs/check_memdb.c > index 74728df..616ae61 100644 > --- a/src/pmxcfs/check_memdb.c > +++ b/src/pmxcfs/check_memdb.c > @@ -270,10 +270,13 @@ START_TEST(test_indextest1) { > ck_assert(sha256 !=3D NULL); > g_checksum_update(sha256, (unsigned char *)idx, idx->bytes); > const char *csum =3D g_checksum_get_string(sha256); > - ck_assert_msg( > - strcmp(csum, "913fd95015af9d93f10dd51ba2a7bb11351bcfe040be21e95f= cba834adc3ec10") =3D=3D 0, > - "wrong idx checksum %s", csum > - ); > + /* the index and its per-entry digests are built from host-endian in= tegers */ > +#if G_BYTE_ORDER =3D=3D G_BIG_ENDIAN > + const char *expected =3D "efdfcdde67acb6b48e4b415a172d5a1897c725b03a= 9b2c12d20efe0ab8adad44"; > +#else > + const char *expected =3D "913fd95015af9d93f10dd51ba2a7bb11351bcfe040= be21e95fcba834adc3ec10"; > +#endif > + ck_assert_msg(strcmp(csum, expected) =3D=3D 0, "wrong idx checksum %= s", csum); > g_free(idx); > g_free(testdata); > }